Bug 45357

Summary: new-run-webkit-tests - fix regression of unit tests on non-Mac platforms
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan, tkent, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Dirk Pranke
Reported 2010-09-07 19:01:40 PDT
new-run-webkit-tests - fix regression of unit tests on non-Mac platforms
Attachments
Patch (4.25 KB, patch)
2010-09-07 19:03 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2010-09-07 19:57 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-09-07 19:03:38 PDT
Created attachment 66829 [details] Patch
Dirk Pranke
Comment 2 2010-09-07 19:05:24 PDT
bug 45090 caused test-webkitpy to fail on non-mac platforms. This should fix things.
Kent Tamura
Comment 3 2010-09-07 19:08:13 PDT
Comment on attachment 66829 [details] Patch Looks OK.
Dirk Pranke
Comment 4 2010-09-07 19:23:29 PDT
Committed r66945: <http://trac.webkit.org/changeset/66945>
Dirk Pranke
Comment 5 2010-09-07 19:24:24 PDT
landed w/ one additional change to not try to run the check_image_diff() unit test if the image diff executable is not available; for some reason, it doesn't seem to be available on the SnowLeopard Leaks bot.
Dirk Pranke
Comment 6 2010-09-07 19:57:42 PDT
Created attachment 66834 [details] Patch
Dirk Pranke
Comment 7 2010-09-07 20:01:26 PDT
Committed r66947: <http://trac.webkit.org/changeset/66947>
Tony Chang
Comment 8 2010-09-08 09:29:07 PDT
Comment on attachment 66834 [details] Patch Only the last method counts in python. Clearing from the review queue.
Note You need to log in before you can comment on or make changes to this bug.