Bug 45357

Summary:

new-run-webkit-tests - fix regression of unit tests on non-Mac platforms

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ojan, tkent, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Dirk Pranke 2010-09-07 19:01:40 PDT

new-run-webkit-tests - fix regression of unit tests on non-Mac platforms

Comment 1 Dirk Pranke 2010-09-07 19:03:38 PDT

Created attachment 66829 [details]
Patch

Comment 2 Dirk Pranke 2010-09-07 19:05:24 PDT

bug 45090 caused test-webkitpy to fail on non-mac platforms. This should fix things.

Comment 3 Kent Tamura 2010-09-07 19:08:13 PDT

Comment on attachment 66829 [details]
Patch

Looks OK.

Comment 4 Dirk Pranke 2010-09-07 19:23:29 PDT

Committed r66945: <http://trac.webkit.org/changeset/66945>

Comment 5 Dirk Pranke 2010-09-07 19:24:24 PDT

landed w/ one additional change to not try to run the check_image_diff() unit test if the image diff executable is not available; for some reason, it doesn't seem to be available on the SnowLeopard Leaks bot.

Comment 6 Dirk Pranke 2010-09-07 19:57:42 PDT

Created attachment 66834 [details]
Patch

Comment 7 Dirk Pranke 2010-09-07 20:01:26 PDT

Committed r66947: <http://trac.webkit.org/changeset/66947>

Comment 8 Tony Chang 2010-09-08 09:29:07 PDT

Comment on attachment 66834 [details]
Patch

Only the last method counts in python.

Clearing from the review queue.