Bug 45352

Summary:

Missing EOL in expected test results

Product:

WebKit

Reporter:

Yael <yael>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Yael

Reported 2010-09-07 18:28:35 PDT

EOL are missing from the expected results of the new test fast/notifications/notifications-click-event.html. This was not found until now because of https://bugs.webkit.org/show_bug.cgi?id=36983. I am about to submit a patch for https://bugs.webkit.org/show_bug.cgi?id=44836, so I need the results to be corrected. A patch is coming.

Attachments
Patch (1.06 KB, patch) 2010-09-07 18:35 PDT, Yael	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yael

Comment 1 2010-09-07 18:35:26 PDT

Created attachment 66820 [details] Patch Added missing EOL from test result.

Antonio Gomes

Comment 2 2010-09-07 18:36:50 PDT

WebKit Commit Bot

Comment 3 2010-09-08 05:38:30 PDT

Comment on attachment 66820 [details] Patch Clearing flags on attachment: 66820 Committed r66974: <http://trac.webkit.org/changeset/66974>

WebKit Commit Bot

Comment 4 2010-09-08 05:38:35 PDT

All reviewed patches have been landed. Closing bug.

Ademar Reis

Comment 5 2010-09-13 07:23:49 PDT

Revision r66974 cherry-picked into qtwebkit-2.1 with commit 82ccd13f2c6b19cc8f276668db45dd5f928705fd

Note You need to log in before you can comment on or make changes to this bug.