Bug 45350

Summary: Null deref in RenderBlock::findNextLineBreak()
Product: WebKit Reporter: Cris Neckar <cdn>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
repro
none
Patch none

Cris Neckar
Reported 2010-09-07 18:20:18 PDT
Created attachment 66816 [details] repro A textnode with a fixed position and first-line styling may resturn null for style(). This is then derefed causing a crash. I will submit a patch shortly.
Attachments
repro (263 bytes, text/html)
2010-09-07 18:20 PDT, Cris Neckar 		no flags
Details
Patch (2.80 KB, patch)
2010-09-08 10:29 PDT, Cris Neckar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cris Neckar
Comment 1 2010-09-08 10:29:57 PDT
Created attachment 66910 [details] Patch
chris fleizach
Comment 2 2010-09-10 02:07:45 PDT
Comment on attachment 66910 [details] Patch You should consider using the format other fast tests use with js-test-pre.js, and js-test-post.js. Many examples abound in fast/dom
WebKit Commit Bot
Comment 3 2010-09-10 02:45:35 PDT
Comment on attachment 66910 [details] Patch Clearing flags on attachment: 66910 Committed r67183: <http://trac.webkit.org/changeset/67183>
WebKit Commit Bot
Comment 4 2010-09-10 02:45:40 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-09-10 05:44:29 PDT
http://trac.webkit.org/changeset/67183 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67183 http://trac.webkit.org/changeset/67191
Note You need to log in before you can comment on or make changes to this bug.