Bug 45337
| Summary: | Make failing webgl tests pass in chromium | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zhenyao Mo <zmo> |
| Component: | WebGL | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | enne, gman, kbr, zmo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Zhenyao Mo
Currently we have several tests being skipped in chromium Mac (LayoutTests/platform/chromium/test_expectations.txt), including:
null-object-behaviour.html
uniform-location.html
texture-npot.html
tex-image-and-sub-image-2d-with-video.html
css-webkit-canvas-repaint.html
css-webkit-canvas.html
gl-teximage.html
It seems like the time to make them all pass.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrienne Walker
tex-image-and-sub-image-2d-with-video.html is filed as 44459. I'm currently looking into that, although I'm not making much progress on it at this point.
Zhenyao Mo
Below is the currently failing webgl tests in chromium (linux, mac, and win)
// These two are failing due to new-run-webkit-tests's diff trimming line ends.
BUGWEBGL MAC : fast/canvas/webgl/null-object-behaviour.html = TEXT
BUGWEBGL MAC : fast/canvas/webgl/uniform-location.html = TEXT
// This will pass once multisampling is implemented in command buffer port. enne@google is working on it.
BUGWEBGL WIN LINUX : fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html = TEXT
// These two might just need a rebaseline. zmo@google will look into it.
BUGWEBGL : fast/canvas/webgl/css-webkit-canvas-repaint.html = IMAGE
BUGWEBGL : fast/canvas/webgl/css-webkit-canvas.html = IMAGE
// Not clear why this is failing. Will create a bug.
BUGWEBGL WIN LINUX : fast/canvas/webgl/gl-object-get-calls.html = TEXT
// zmo@google will look into this. It only fails on leopard.
BUGWEBGL MAC : fast/canvas/webgl/gl-teximage.html = TEXT
// Not clear why this is failing. Will create a bug.
BUGWEBGL WIN LINUX : fast/canvas/webgl/gl-uniform-arrays.html = TEXT
// Will create a bug for this. Need to do the same thing in command buffer as we did in the other two ports.
BUGWEBGL WIN LINUX : fast/canvas/webgl/point-size.html = TEXT
// enne@google is working on this.
BUGWEBGL MAC : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TEXT PASS
// This might be a Mac gl driver bug. Will create a bug on this.
BUGWEBGL MAC : fast/canvas/webgl/texture-npot.html = TEXT
// Not clear why this is failing. Will create a bug.
BUGWEBGL WIN LINUX : fast/canvas/webgl/uniform-location.html = TEXT
Zhenyao Mo
Also, webgl tests are quite flaky in DumperRenderTree. There are a lot of entries for Chromium Mac. I added a lot of entries for chromium Linux in r67715.
Zhenyao Mo
Only nine left for now.
BUGWEBGL : fast/canvas/webgl/css-webkit-canvas-repaint.html = IMAGE
BUGWEBGL : fast/canvas/webgl/css-webkit-canvas.html = IMAGE
BUGWEBGL WIN MAC : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TEXT PASS
BUGWEBGL : fast/canvas/webgl/gl-uniform-arrays.html = TEXT
BUGWEBGL : fast/canvas/webgl/object-deletion-behaviour.html = TEXT
BUGWEBGL : fast/canvas/webgl/point-size.html = TEXT
BUGWEBGL : fast/canvas/webgl/gl-object-get-calls.html = TIMEOUT PASS
BUGWEBGL : fast/canvas/webgl/tex-image-and-uniform-binding-bugs.html = TIMEOUT PASS
BUGWEBGL : fast/canvas/webgl/uniform-location.html = TIMEOUT PASS
Stephen Chenney
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.