Bug 45336

Summary: Fix OpenGL error reporting in WebGL layout test utilities
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 45332    
Attachments:
Description Flags
Patch jamesr: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-09-07 16:45:09 PDT
There is a bug in getGLErrorAsString (LayoutTests/fast/canvas/webgl/resources/webgl-test.js) where if for some reason the error code is not found in the context object, the error code is not properly output. This is affecting the error reporting for https://bugs.webkit.org/show_bug.cgi?id=45332 .
Attachments
Patch (1.07 KB, patch)
2010-09-07 16:48 PDT, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-09-07 16:48:44 PDT
Created attachment 66788 [details] Patch
James Robinson
Comment 2 2010-09-07 16:51:37 PDT
Comment on attachment 66788 [details] Patch Looks good!
Kenneth Russell
Comment 3 2010-09-07 16:56:45 PDT
Committed r66934: <http://trac.webkit.org/changeset/66934>
Note You need to log in before you can comment on or make changes to this bug.