Bug 45328

Summary: [GTK] WebKitWebView should not descend from GtkContainer
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: gustavo, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch for this issue
none
Patch also removing the private children member from WebKitWebView gustavo: review-

Martin Robinson
Reported 2010-09-07 15:33:19 PDT
Now that we no longer need to add GtkScrollbars to the WebKitWebView, we do not need to treat it like a GtkContainer. This has the added benefit of being less confusing to developers.
Attachments
Patch for this issue (4.02 KB, patch)
2010-09-07 15:41 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch also removing the private children member from WebKitWebView (4.56 KB, patch)
2010-09-10 09:20 PDT, Martin Robinson 		gustavo: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-09-07 15:41:44 PDT
Created attachment 66778 [details] Patch for this issue
Xan Lopez
Comment 2 2010-09-07 23:53:47 PDT
Comment on attachment 66778 [details] Patch for this issue I suppose you know, but this is an ABI break.
Xan Lopez
Comment 3 2010-09-07 23:56:06 PDT
The patch looks good to me otherwise, so if we agree to break ABI I say we go for it.
Martin Robinson
Comment 4 2010-09-10 09:20:16 PDT
Created attachment 67192 [details] Patch also removing the private children member from WebKitWebView
Gustavo Noronha (kov)
Comment 5 2010-09-24 10:31:47 PDT
Comment on attachment 67192 [details] Patch also removing the private children member from WebKitWebView I'm afraid we can't do this yet because plugins are added to the WebView. See: http://trac.webkit.org/browser/trunk/WebCore/plugins/gtk/PluginViewGtk.cpp#L804
Martin Robinson
Comment 6 2010-09-24 10:32:23 PDT
You're right. :/ Once plugins are out-of-process I'll mark this for review again.
Gustavo Noronha (kov)
Comment 7 2010-09-24 10:33:51 PDT
I do think this is the sensible thing to do once we don't need to add more stuff to it. I don't think any API users should be relying on the fact that the WebKitWebView is a container.
Note You need to log in before you can comment on or make changes to this bug.