Bug 45317

Summary: Encapsulate multi-column rectangle information
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch bdakin: review+

Dave Hyatt
Reported 2010-09-07 12:51:16 PDT
Encapsulate multi-column rectangle information to avoid exposing the Vector. This allows for future code (layout pagination code) to not have to store a Vector of rects (the rects can just be computed from a count and height for example).
Attachments
Patch (21.03 KB, patch)
2010-09-07 12:55 PDT, Dave Hyatt 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-07 12:55:05 PDT
Created attachment 66753 [details] Patch
WebKit Review Bot
Comment 2 2010-09-07 12:57:53 PDT
Attachment 66753 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/rendering/ColumnInfo.h:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2010-09-07 12:59:52 PDT
Fixed in r66903.
Note You need to log in before you can comment on or make changes to this bug.