Bug 45283 – [DRT/Chromium] Implement --check-layout-test-sys-deps

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kent Tamura]

[DRT/Chromium] Implement --check-layout-test-sys-deps

[Kent Tamura]

Created attachment 66685 [details]
Patch

[Kent Tamura]

Note:
The original code is here: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_platform_delegate_win.cc?annotate=42071#l39

When this change is committed, the Windows test buildbot might stop working.  We need to change the local machine settings in that case.

[Dimitri Glazkov (Google)]

Comment on attachment 66685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66685&action=prettypatch

ok.

> WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:201
> +    int verticalScrollSize = ::GetSystemMetrics(SM_CXVSCROLL);
I wonder if I took care of this requirement and it's no longer necessary to check for . Not sure :)

[Kent Tamura]

Comment on attachment 66685 [details]
Patch

Clearing flags on attachment: 66685

Committed r66906: <http://trac.webkit.org/changeset/66906>

[Kent Tamura]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/66906 might have broken Leopard Intel Debug (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/66905
http://trac.webkit.org/changeset/66906