Bug 45262

Summary:

Web Inspector: upstream two debugger tests

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch.	none
Remove old tests from chromium	none
Use InspectorTest.captureStackTrace to dump stack.	none
Use InspectorTest.captureStackTrace to dump stack.	none

Pavel Podivilov

Reported 2010-09-06 06:43:57 PDT

Web Inspector: upstream two debugger tests

Attachments
Proposed patch. (5.10 KB, patch) 2010-09-06 07:13 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Remove old tests from chromium (7.74 KB, patch) 2010-09-06 07:20 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Use InspectorTest.captureStackTrace to dump stack. (8.27 KB, patch) 2010-09-06 08:29 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Use InspectorTest.captureStackTrace to dump stack. (7.85 KB, patch) 2010-09-06 08:32 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2010-09-06 07:13:17 PDT

Created attachment 66638 [details] Proposed patch.

Pavel Podivilov

Comment 2 2010-09-06 07:20:44 PDT

Created attachment 66641 [details] Remove old tests from chromium

Yury Semikhatsky

Comment 3 2010-09-06 07:36:57 PDT

Comment on attachment 66641 [details] Remove old tests from chromium View in context: https://bugs.webkit.org/attachment.cgi?id=66641&action=prettypatch > LayoutTests/inspector/debugger-pause-on-breakpoint.html:31 > + InspectorTest.addResult("line: " + callFrames[0].line + ", function: " + callFrames[0].functionName); Please use InspectorTest.captureStackTrace for this. > LayoutTests/inspector/debugger-pause-on-exception.html:36 > + InspectorTest.addResult("line: " + callFrames[0].line + ", function: " + callFrames[0].functionName); Please use InspectorTest.captureStackTrace for this. > WebKit/chromium/src/js/Tests.js:-634 > -TestSuite.prototype.testSetBreakpoint = function() Make sure to remove Chromium code that invokes them before landing this patch. cq- for this.

Pavel Podivilov

Comment 4 2010-09-06 08:29:24 PDT

Created attachment 66647 [details] Use InspectorTest.captureStackTrace to dump stack.

Pavel Podivilov

Comment 5 2010-09-06 08:32:44 PDT

Created attachment 66648 [details] Use InspectorTest.captureStackTrace to dump stack.

Eric Seidel (no email)

Comment 6 2010-09-07 03:19:01 PDT

Comment on attachment 66641 [details] Remove old tests from chromium Cleared Yury Semikhatsky's review+ from obsolete attachment 66641 [details] so that this bug does not appear in http://webkit.org/pending-commit.

WebKit Commit Bot

Comment 7 2010-09-07 03:55:56 PDT

Comment on attachment 66648 [details] Use InspectorTest.captureStackTrace to dump stack. Rejecting patch 66648 from commit-queue. podivilov@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

WebKit Commit Bot

Comment 8 2010-09-07 05:28:58 PDT

Comment on attachment 66648 [details] Use InspectorTest.captureStackTrace to dump stack. Clearing flags on attachment: 66648 Committed r66877: <http://trac.webkit.org/changeset/66877>

WebKit Commit Bot

Comment 9 2010-09-07 05:29:03 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 10 2010-09-07 05:55:00 PDT

http://trac.webkit.org/changeset/66877 might have broken Qt Linux Release

Note You need to log in before you can comment on or make changes to this bug.