Bug 45257

Summary: Add new API required for bug 45112
Product: WebKit Reporter: Jonathan Dixon <joth>
Component: WebKit APIAssignee: Jonathan Dixon <joth>
Severity: Normal CC: bulach, commit-queue, jorlow, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
Add the API
Remove \t char none

Description Jonathan Dixon 2010-09-06 04:28:17 PDT
Before the fix for https://bugs.webkit.org/show_bug.cgi?id=45112 can be landed, http://codereview.chromium.org/3338008/show must be landed on the chromium side.
This in turn relies on the new WebGeolocationServiceBridge::onWebGeolocationServiceDestroyed() API existing on the webkit side -- this bug is for tracking that item.
Comment 1 Jonathan Dixon 2010-09-06 04:30:49 PDT
Created attachment 66623 [details]
Add the API
Comment 2 WebKit Review Bot 2010-09-06 04:31:34 PDT
Attachment 66623 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jonathan Dixon 2010-09-06 04:32:59 PDT
Created attachment 66624 [details]
Remove \t char
Comment 4 Jeremy Orlow 2010-09-06 04:41:33 PDT
Comment on attachment 66624 [details]
Remove \t char


Joth please wait until Marcus has signed off on this though.
Comment 5 Marcus Bulach 2010-09-06 05:43:31 PDT

thanks joth and jeremy!

(In reply to comment #4)
> (From update of attachment 66624 [details])
> r=me
> Joth please wait until Marcus has signed off on this though.
Comment 6 Jonathan Dixon 2010-09-06 07:30:33 PDT
Thanks for the reviews. Could one of you commit queue it please?
Comment 7 WebKit Commit Bot 2010-09-06 10:10:23 PDT
Comment on attachment 66624 [details]
Remove \t char

Clearing flags on attachment: 66624

Committed r66837: <http://trac.webkit.org/changeset/66837>
Comment 8 WebKit Commit Bot 2010-09-06 10:10:28 PDT
All reviewed patches have been landed.  Closing bug.