Bug 45257

Summary:

Add new API required for bug 45112

Product:

WebKit

Reporter:

Jonathan Dixon <joth>

Component:

WebKit API

Assignee:

Jonathan Dixon <joth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bulach, commit-queue, jorlow, steveblock, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Add the API	none
Remove \t char	none

Jonathan Dixon

Reported 2010-09-06 04:28:17 PDT

Before the fix for https://bugs.webkit.org/show_bug.cgi?id=45112 can be landed, http://codereview.chromium.org/3338008/show must be landed on the chromium side. This in turn relies on the new WebGeolocationServiceBridge::onWebGeolocationServiceDestroyed() API existing on the webkit side -- this bug is for tracking that item.

Attachments
Add the API (2.61 KB, patch) 2010-09-06 04:30 PDT, Jonathan Dixon	no flags	Details Formatted Diff Diff
Remove \t char (2.62 KB, patch) 2010-09-06 04:32 PDT, Jonathan Dixon	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jonathan Dixon

Comment 1 2010-09-06 04:30:49 PDT

Created attachment 66623 [details] Add the API

WebKit Review Bot

Comment 2 2010-09-06 04:31:34 PDT

Attachment 66623 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jonathan Dixon

Comment 3 2010-09-06 04:32:59 PDT

Created attachment 66624 [details] Remove \t char

Jeremy Orlow

Comment 4 2010-09-06 04:41:33 PDT

Comment on attachment 66624 [details] Remove \t char r=me Joth please wait until Marcus has signed off on this though.

Marcus Bulach

Comment 5 2010-09-06 05:43:31 PDT

LGTM thanks joth and jeremy! (In reply to comment #4) > (From update of attachment 66624 [details]) > r=me > > Joth please wait until Marcus has signed off on this though.

Jonathan Dixon

Comment 6 2010-09-06 07:30:33 PDT

Thanks for the reviews. Could one of you commit queue it please? Cheers

WebKit Commit Bot

Comment 7 2010-09-06 10:10:23 PDT

Comment on attachment 66624 [details] Remove \t char Clearing flags on attachment: 66624 Committed r66837: <http://trac.webkit.org/changeset/66837>

WebKit Commit Bot

Comment 8 2010-09-06 10:10:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.