Summary: | [EFL] Need to add custom dependencies. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | antognolli+webkit, leandro, lucas.de.marchi, tonikitoo | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | Linux | ||||||||||||||
Attachments: |
|
Description
Ryuan Choi
2010-09-05 21:28:52 PDT
Created attachment 66606 [details]
Patch
Created attachment 66612 [details]
Patch
Comment on attachment 66612 [details] Patch > Index: WebKit/ChangeLog > =================================================================== > --- WebKit/ChangeLog (revision 66809) > +++ WebKit/ChangeLog (working copy) > @@ -1,3 +1,14 @@ > +2010-09-05 Ryuan Choi <ryuan.choi@samsung.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [EFL] PORT_DEPENDENCY to add custom target in CMake system What did you mean? [EFL] Add theme as dependency to > + https://bugs.webkit.org/show_bug.cgi?id=45247 > + > + Add WEBKIT_PORT_DEPENDENCIES to include custom target for each port. I'd reword to something like: Add WEBKIT_PORT_DEPENDENCIES to include custom dependencies for each port. Otherwise, it looks good. Created attachment 66690 [details]
Patch
(In reply to comment #3) > (From update of attachment 66612 [details]) > > Index: WebKit/ChangeLog > > =================================================================== > > --- WebKit/ChangeLog (revision 66809) > > +++ WebKit/ChangeLog (working copy) > > @@ -1,3 +1,14 @@ > > +2010-09-05 Ryuan Choi <ryuan.choi@samsung.com> > > + > > + Reviewed by NOBODY (OOPS!). > > + > > + [EFL] PORT_DEPENDENCY to add custom target in CMake system > What did you mean? > > [EFL] Add theme as dependency to > > + https://bugs.webkit.org/show_bug.cgi?id=45247 > > + > > + Add WEBKIT_PORT_DEPENDENCIES to include custom target for each port. > I'd reword to something like: > > Add WEBKIT_PORT_DEPENDENCIES to include custom dependencies for each port. > > > Otherwise, it looks good. thank you. I created patch like you mentioned. (In reply to comment #5) > > thank you. > I created patch like you mentioned. Humn, sorry. Looking again at this issue, I think a much cleaner approach would be to apply the following patch. It just adds the theme to WebKit's source list. Leandro, Ryuan, what do you think? diff --git a/WebKit/efl/CMakeListsEfl.txt b/WebKit/efl/CMakeListsEfl.txt index cff1822..57cacae 100644 --- a/WebKit/efl/CMakeListsEfl.txt +++ b/WebKit/efl/CMakeListsEfl.txt @@ -159,6 +159,10 @@ ADD_CUSTOM_COMMAND( VERBATIM ) +LIST(APPEND WebKit_SOURCES + ${WebKit_THEME} +) + IF (SHARED_CORE) SET(LIBS_PRIVATE "-l${WTF_LIBRARY_NAME} -l${JavaScriptCore_LIBRARY_NAME} -l${WebCore_LIBRARY_NAME}") ELSE () Created attachment 66897 [details]
Patch
(In reply to comment #7) > Created an attachment (id=66897) [details] > Patch (In reply to comment #6) > (In reply to comment #5) > > > > thank you. > > I created patch like you mentioned. > > > Humn, sorry. Looking again at this issue, I think a much cleaner approach would be to apply the following patch. It just adds the theme to WebKit's source list. > > Leandro, Ryuan, what do you think? > > > diff --git a/WebKit/efl/CMakeListsEfl.txt b/WebKit/efl/CMakeListsEfl.txt > index cff1822..57cacae 100644 > --- a/WebKit/efl/CMakeListsEfl.txt > +++ b/WebKit/efl/CMakeListsEfl.txt > @@ -159,6 +159,10 @@ ADD_CUSTOM_COMMAND( > VERBATIM > ) > > +LIST(APPEND WebKit_SOURCES > + ${WebKit_THEME} > +) > + > IF (SHARED_CORE) > SET(LIBS_PRIVATE "-l${WTF_LIBRARY_NAME} -l${JavaScriptCore_LIBRARY_NAME} -l${WebCore_LIBRARY_NAME}") > ELSE () LGTM, Conceptually, it's not a source. but it's simple than before. I tested and upload patch you mentioned. Created attachment 66899 [details]
Patch
Committed r67011: <http://trac.webkit.org/changeset/67011> Comment on attachment 66899 [details]
Patch
Clearing flags
|