Bug 45219

Summary: Make SecurityOrigin::canDisplay an instance function
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2010-09-03 17:59:48 PDT
Make SecurityOrigin::canDisplay an instance function
Attachments
Patch (21.09 KB, patch)
2010-09-03 18:03 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (22.46 KB, patch)
2010-09-11 17:54 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-09-03 18:03:22 PDT
Created attachment 66575 [details] Patch
Adam Barth
Comment 2 2010-09-10 23:09:57 PDT
Comment on attachment 66575 [details] Patch Thanks for the review.
WebKit Commit Bot
Comment 3 2010-09-10 23:42:59 PDT
Comment on attachment 66575 [details] Patch Rejecting patch 66575 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1 Last 500 characters of output: ginStream.mm patching file WebKit/mac/Plugins/WebNetscapePluginView.mm patching file WebKit/mac/Plugins/WebPluginContainerCheck.mm patching file WebKit/mac/WebView/WebFrame.mm Hunk #1 succeeded at 1265 (offset -17 lines). patching file WebKit/win/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/win/WebFrame.cpp Hunk #1 succeeded at 1345 (offset -7 lines). patching file WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit2/WebProcess/Plugins/PluginView.cpp Full output: http://queues.webkit.org/results/3906390
Adam Barth
Comment 4 2010-09-11 17:54:56 PDT
Created attachment 67320 [details] Patch for landing
WebKit Commit Bot
Comment 5 2010-09-11 19:28:36 PDT
Comment on attachment 67320 [details] Patch for landing Clearing flags on attachment: 67320 Committed r67316: <http://trac.webkit.org/changeset/67316>
WebKit Commit Bot
Comment 6 2010-09-11 19:28:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.