| Summary: | Rename SecurityOrigin::canLoad to canDisplay | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, eric, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2010-09-03 16:24:00 PDT
Created attachment 66563 [details]
Patch
Comment on attachment 66563 [details] Patch > + // Returns true if |document| can dispaly content from the given URL (e.g., dispaly > + // in an iframe or as an image). For example, web sites generally cannot > + // display content from the user's files system. If |document| is 0, > + // |referrer| is used to make this determination. Are we going to have to go out into the alley and have a throw down over the two spaces vs. one space after period issue? ;-) In the programming world I am part of, the word "display" usually means "paint into a window", so I think the word display here is not perfect. Is there some terminology from the HTML5 specification or some other technical document that we can borrow here to find a phrase better than "display the contents"? Thanks for the review. > Are we going to have to go out into the alley and have a throw down over the two spaces vs. one space after period issue? ;-) Sorry. Almost all the prose I write uses two-space indent. :( > In the programming world I am part of, the word "display" usually means "paint into a window", so I think the word display here is not perfect. Is there some terminology from the HTML5 specification or some other technical document that we can borrow here to find a phrase better than "display the contents"? canShow? canRender? My main beef with canLoad is that it's too similar to canRequest. Actually, "paint into a window" is pretty accurate here. For example, that's pretty much what the image element does with the URL... Created attachment 66614 [details]
Patch for landing
Comment on attachment 66614 [details] Patch for landing Clearing flags on attachment: 66614 Committed r66815: <http://trac.webkit.org/changeset/66815> All reviewed patches have been landed. Closing bug. |