Bug 45080

Summary: Actually parse a URL from ParsedURL
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-09-01 18:35:38 PDT
Actually parse a URL from ParsedURL
Attachments
Patch (1.48 KB, patch)
2010-09-01 18:36 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-09-01 18:36:45 PDT
Created attachment 66309 [details] Patch
Eric Seidel (no email)
Comment 2 2010-09-01 18:39:14 PDT
Comment on attachment 66309 [details] Patch OK.
WebKit Commit Bot
Comment 3 2010-09-02 07:35:46 PDT
Comment on attachment 66309 [details] Patch Rejecting patch 66309 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Last 500 characters of output: cceeded at 1 with fuzz 3. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: JavaScriptCore/wtf/url/api/ParsedURL.cpp |index 0ee586402a56f5884cc4d54a718412110c1f1f5a..abe0061b1f1410775b69a64315c35f07a0aaaeb0 100644 |--- JavaScriptCore/wtf/url/api/ParsedURL.cpp |+++ JavaScriptCore/wtf/url/api/ParsedURL.cpp -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Full output: http://queues.webkit.org/results/3932055
Adam Barth
Comment 4 2010-09-02 11:26:40 PDT
Comment on attachment 66309 [details] Patch The earlier patch was rejected because of a flaky test. Let's try this again.
WebKit Commit Bot
Comment 5 2010-09-02 19:17:49 PDT
Comment on attachment 66309 [details] Patch Clearing flags on attachment: 66309 Committed r66706: <http://trac.webkit.org/changeset/66706>
WebKit Commit Bot
Comment 6 2010-09-02 19:17:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.