Bug 4508 – Layout tests access an external server

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

layout-tests/fast/block/float/014.html uses an image from Macromedia web site:

<img src="http://www.macromedia.com/images/shared/editorial/60x45/training_thumb.jpg" />

This test doesn't include a description of what's being tested, but accessing an outside server doesn't 
seem necessary...

[Alexey Proskuryakov]

One more: layout-tests/fast/lists/009.html

list-style: disc url(http://www.alistapart.com/i/listmark.gif) inside;

[Alexey Proskuryakov]

layout-tests/fast/lists/009.html was fixed on 2005-08-23 by Darin Adler, according to the ChangeLog. 
The other one is still there.

[Alexey Proskuryakov]

Several of the newly-added XHTML tests access an external server (xw2k.sdct.itl.nist.gov), too:

dom/xhtml/level2/html/HTMLBodyElement01.xhtml
dom/xhtml/level2/html/HTMLBodyElement02.xhtml
...
(searching in LayoutTests revealed 83 occurences of this URL)

[Alexey Proskuryakov]

dom/xhtml/level2/html tests have been fixed in r12776. The current list of offending tests is:

fast/block/float/014.html
fast/dom/HTMLImageElement/image-src-absolute-url.html
fast/loader/docLoaderFrame.html

[David Kilzer (:ddkilzer)]

*** Bug 7825 has been marked as a duplicate of this bug. ***

[Darin Adler]

After landing the fix for bug 8142, float/014 is fixed.

So now image-src-absolute-url and docLoaderFrame are the two remaining.

[Alexey Proskuryakov]

Created attachment 10366 [details]
proposed fix

[Alexey Proskuryakov]

It would also be good to prevent DumpRenderTree from accessing external resources now, but I'm not sure about the right approach.

[Timothy Hatcher]

Comment on attachment 10366 [details]
proposed fix

Looks good.

To prevent DRT from accessing external source you will need to hook up the resource load delegate and look at the URLs it tries to load, preventing remote URLs.

[Alexey Proskuryakov]

Filed bug 10707 for DRT enhancements.

[Alexey Proskuryakov]

Committed revision 16196.