Bug 45063

Summary: [Chromium] Update test results server to make sure it does not have corrupted data
Product: WebKit Reporter: Victor Wang <victorw>
Component: Tools / TestsAssignee: Victor Wang <victorw>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch ojan: review+

Victor Wang
Reported 2010-09-01 14:56:27 PDT
The results.json file size could be >1M (data store entry limit), so we split it into multiple data store entries in this case. The current test results server may leave the data in corrupted state if data store error happens in the middle of saving multiple entries. To fix this, we should save keys to the new data entries separately and set the data_keys in DataStoreFile only when all data are saved successfully. This avoids the issue that only partial results are saved.
Attachments
Proposed Patch (3.35 KB, patch)
2010-09-01 15:09 PDT, Victor Wang 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2010-09-01 15:09:15 PDT
Created attachment 66285 [details] Proposed Patch
Ojan Vafai
Comment 2 2010-09-08 14:32:54 PDT
Comment on attachment 66285 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66285&action=prettypatch > WebKitTools/ChangeLog:11 > + be corrupted if data store error happens in teh middle typo: teh
Victor Wang
Comment 3 2010-09-08 15:16:48 PDT
Committed r67024: <http://trac.webkit.org/changeset/67024>
Note You need to log in before you can comment on or make changes to this bug.