Bug 45050

Summary:

dumpAsText/Markup conversion: editing/style/block-style-004.html through block-style-006.html and editing/style/fontsize-1.html

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

darin, enrica, ojan, tkent, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

45026

Attachments:

Description	Flags
converted tests	tkent: review+

Ryosuke Niwa

Reported 2010-09-01 12:45:43 PDT

The following tests should be converted to a dump-as-text tests: editing/style/block-style-004.html editing/style/block-style-005.html editing/style/block-style-006.html The following test should be converted to a dump-as-markup test: editing/style/fontsize-1.html None of the tests need to demonstrate the correctness of rendering.

Attachments
converted tests (85.51 KB, patch) 2010-09-01 12:50 PDT, Ryosuke Niwa	tkent: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2010-09-01 12:50:11 PDT

Created attachment 66246 [details] converted tests

Ryosuke Niwa

Comment 2 2010-09-01 12:51:07 PDT

Note that the change itself is small. Most of 85KB is about deleting platform-specific results.

Kent Tamura

Comment 3 2010-09-01 16:51:11 PDT

Comment on attachment 66246 [details] converted tests OK.

Ryosuke Niwa

Comment 4 2010-09-02 12:06:16 PDT

Thanks for the review, Kent. (In reply to comment #3) > (From update of attachment 66246 [details]) > OK.

Ryosuke Niwa

Comment 5 2010-09-02 12:07:01 PDT

Committed r66678: <http://trac.webkit.org/changeset/66678>

Note You need to log in before you can comment on or make changes to this bug.