Bug 45036 – [v8] bypass caches when query memory usage from post GC and in crash handler.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[anton muhin]

[v8] bypass caches when query memory usage from post GC and in crash handler.

[anton muhin]

Created attachment 66212 [details]
Patch

[Adam Barth]

Comment on attachment 66212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66212&action=prettypatch

> WebCore/bindings/v8/V8GCController.cpp:400
> -int getMemoryUsageInMB()
> +int getMemoryUsageInMB(bool noCache)
Instead of using a bool, please use an enum so we can understand what passing "true" means at the callsites.

[anton muhin]

(In reply to comment #2)
> (From update of attachment 66212 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66212&action=prettypatch
> 
> > WebCore/bindings/v8/V8GCController.cpp:400
> > -int getMemoryUsageInMB()
> > +int getMemoryUsageInMB(bool noCache)
> Instead of using a bool, please use an enum so we can understand what passing "true" means at the callsites.

Adam, Chromium's counterpart to this change has been backed out, so, please, let put on hold this review.  I'll address your comment and request for another round when I am done with Chromium side.

Sorry for troubles.

[anton muhin]

Created attachment 66531 [details]
Patch

[anton muhin]

Adam, may you have a look?

Now I should really start with extending Chromium's API.

[Adam Barth]

Comment on attachment 66531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66531&action=prettypatch

> WebCore/platform/chromium/ChromiumBridge.h:194
> +        // Same as above, but always returns actual value, without any caches.
> +        static int actualMemoryUsageMB();
Much nicer.

[anton muhin]

Comment on attachment 66531 [details]
Patch

Thanks a lot for review, Adam.

[WebKit Commit Bot]

Comment on attachment 66531 [details]
Patch

Clearing flags on attachment: 66531

Committed r66818: <http://trac.webkit.org/changeset/66818>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[anton muhin]

Created attachment 66906 [details]
Patch

[anton muhin]

Reopend as that was two sided patch:

1) introduce API in the bridge;
2) commit implementation of API into Chromium proper;
3) actually use the API.

The latest patch corresponds to phase 3.

[anton muhin]

Adam, may you have a look, please?

[WebKit Commit Bot]

Comment on attachment 66906 [details]
Patch

Clearing flags on attachment: 66906

Committed r67111: <http://trac.webkit.org/changeset/67111>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[anton muhin]

Thanks a lot for review, Adam