Bug 45031

Summary:

[chromium] move out the dftables invokation of the pcre target

Product:

WebKit

Reporter:

jochen

Component:

New Bugs

Assignee:

jochen

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

jochen

Reported 2010-09-01 03:56:20 PDT

[chromium] move out the dftables invokation of the pcre target

Attachments
Patch (2.18 KB, patch) 2010-09-01 04:00 PDT, jochen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

jochen

Comment 1 2010-09-01 04:00:39 PDT

Created attachment 66196 [details] Patch

Tony Chang

Comment 2 2010-09-02 16:17:18 PDT

Comment on attachment 66196 [details] Patch This sounds fine to me, but can you explain why? Is it to make the build a little more parallel? > diff --git a/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp b/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp > - 'target_name': 'pcre', > - 'type': '<(library)', > + 'target_name': 'dftables', > + 'type': 'none', > 'dependencies': [ > 'wtf', > ], Does dftables really depend on wtf?

Eric Seidel (no email)

Comment 3 2010-11-07 23:28:29 PST

Comment on attachment 66196 [details] Patch Cleared review? from attachment 66196 [details] so that this bug does not appear in http://webkit.org/pending-review.

Note You need to log in before you can comment on or make changes to this bug.