Bug 45015

Summary:

Add helpers to FloatRect to compute bounding box from points

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

Layout and Rendering

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, jamesr, senorblanco, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

44729

Attachments:

Description	Flags
Patch	simon.fraser: review+, kbr: commit-queue-

Description Kenneth Russell 2010-08-31 19:15:13 PDT

For some geometric algorithms, it is necessary to compute the bounding box of a set of points. Methods on FloatRect for this purpose would be very helpful.

Comment 1 Kenneth Russell 2010-08-31 19:19:59 PDT

Created attachment 66159 [details]
Patch

From the ChangeLog:

Added fitToPoints, including a few overloaded variants for the cases of two, three and four points. I opted not to add a generalized version taking const FloatRect* or Vector<FloatRect> at the present time because for my own purposes they are unnecessary, and the specific versions can be more tightly coded. Also added left() and top() for symmetry with right() and bottom(). These changes have been tested with new code to be added later.

Comment 2 Simon Fraser (smfr) 2010-08-31 20:24:07 PDT

Comment on attachment 66159 [details]
Patch

r=me but please look at FloatQuad and see if any of the methods in there could be updated.

Comment 3 Kenneth Russell 2010-09-01 09:56:59 PDT

(In reply to comment #2)
> (From update of attachment 66159 [details])
> r=me but please look at FloatQuad and see if any of the methods in there could be updated.

I checked the FloatQuad class but none of these changes apply there.

Comment 4 Kenneth Russell 2010-09-01 09:59:24 PDT

Committed r66611: <http://trac.webkit.org/changeset/66611>