Summary: | WebKit should not accept PDFs as video. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, eric, kbr, webkit.review.bot | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | OS X 10.5 | ||||||||||||||
Bug Depends on: | 45096 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Jer Noble
2010-08-31 17:59:16 PDT
Created attachment 66155 [details]
Disable PDF Components
Created attachment 66271 [details]
Patch
This new patch was significantly different enough to warrant re-review. There was some new code in libWebKitSystemInterface to work around what I thought was a QuickTime bug. Turns out, we just need to disable the PDF components twice (as they're registered twice). Attachment 66271 [details] did not build on mac: Build output: http://queues.webkit.org/results/3918039 Whoops, initializer count mismatch. New patch coming. Created attachment 66274 [details]
Patch
Committed r66622: <http://trac.webkit.org/changeset/66622> http://trac.webkit.org/changeset/66622 might have broken SnowLeopard Intel Release (Tests) Reopening to address the test failure. Created attachment 66331 [details]
Patch
Created attachment 66333 [details] Same as attachment 66331 [details] but with no trailing whitespace Comment on attachment 66333 [details] Same as attachment 66331 [details] but with no trailing whitespace Clearing flags on attachment: 66333 Committed r66652: <http://trac.webkit.org/changeset/66652> Hopefully that will fix things. http://trac.webkit.org/changeset/66652 might have broken Leopard Intel Debug (Tests) |