Bug 45013

Summary: WebKit should not accept PDFs as video.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Severity: Normal CC: abarth, eric, kbr, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 45096    
Bug Blocks:    
Description Flags
Disable PDF Components
darin: review+
Same as attachment 66331 but with no trailing whitespace none

Description Jer Noble 2010-08-31 17:59:16 PDT
<video src="some.pdf"></video> will load a PDF as a video in Safari.
Comment 1 Jer Noble 2010-08-31 17:59:42 PDT
Comment 2 Jer Noble 2010-08-31 18:20:25 PDT
Created attachment 66155 [details]
Disable PDF Components
Comment 3 Jer Noble 2010-09-01 14:19:49 PDT
Created attachment 66271 [details]
Comment 4 Jer Noble 2010-09-01 14:25:50 PDT
This new patch was significantly different enough to warrant re-review.  There was some new code in libWebKitSystemInterface to work around what I thought was a QuickTime bug.  Turns out, we just need to disable the PDF components twice (as they're registered twice).
Comment 5 Eric Seidel (no email) 2010-09-01 14:31:03 PDT
Attachment 66271 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3918039
Comment 6 Jer Noble 2010-09-01 14:38:02 PDT
Whoops, initializer count mismatch.  New patch coming.
Comment 7 Jer Noble 2010-09-01 14:39:26 PDT
Created attachment 66274 [details]
Comment 8 Jer Noble 2010-09-01 15:56:13 PDT
Committed r66622: <http://trac.webkit.org/changeset/66622>
Comment 9 WebKit Review Bot 2010-09-01 19:53:22 PDT
http://trac.webkit.org/changeset/66622 might have broken SnowLeopard Intel Release (Tests)
Comment 10 Jer Noble 2010-09-01 21:44:08 PDT
Reopening to address the test failure.
Comment 11 Jer Noble 2010-09-01 22:16:01 PDT
Created attachment 66331 [details]
Comment 12 Matthew Willis (lilmatt) 2010-09-01 22:33:09 PDT
Created attachment 66333 [details]
Same as attachment 66331 [details] but with no trailing whitespace
Comment 13 Eric Seidel (no email) 2010-09-02 02:32:15 PDT
Comment on attachment 66333 [details]
Same as attachment 66331 [details] but with no trailing whitespace

Clearing flags on attachment: 66333

Committed r66652: <http://trac.webkit.org/changeset/66652>
Comment 14 Eric Seidel (no email) 2010-09-02 02:34:05 PDT
Hopefully that will fix things.
Comment 15 WebKit Review Bot 2010-09-02 09:39:04 PDT
http://trac.webkit.org/changeset/66652 might have broken Leopard Intel Debug (Tests)