Bug 44972 – Expose WorkerContext.createBlobURL and WorkerContext.revokeBlobURL

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Jian Li]

Expose WorkerContext.createBlobURL and WorkerContext.revokeBlobURL

[Jian Li]

Created attachment 66087 [details]
Proposed Patch

[WebKit Review Bot]

Attachment 66087 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/workers/WorkerContext.h:46:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Levin]

Comment on attachment 66087 [details]
Proposed Patch


> diff --git a/WebCore/page/SecurityOrigin.cpp b/WebCore/page/SecurityOrigin.cpp
> +#if ENABLE(BLOB)
> +    // For blob scheme, we want to ignore this check.
> +    if (!url.protocolIs("blob"))
> +        if (targetOrigin->isUnique())
> +            return false;
> +#else
>      if (targetOrigin->isUnique())
>          return false;
> +#endif


Please consider:

bool doUniqueOriginCheck = true;
#if ENABLE(BLOB)
    // For blob scheme, we want to ignore this check.
    doUniqueOriginCheck = !url.protocolIs("blob"));
#endif
    if (doUniqueOriginCheck && targetOrigin->isUnique())
        return false;

[Jian Li]

Committed as http://trac.webkit.org/changeset/66537.