Bug 44966

Summary: REGRESSION(r66484): Broke EFL build (Requested by acidx on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, leandro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 44842    
Attachments:
Description Flags
ROLLOUT of r66484 none

Description WebKit Review Bot 2010-08-31 11:29:32 PDT
http://trac.webkit.org/changeset/66484 broke the build:
Broke EFL build (Requested by acidx on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-08-31 11:29:45 PDT
Created attachment 66077 [details]
ROLLOUT of r66484

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Leandro Pereira 2010-08-31 11:39:33 PDT
Build fails because JSMathMLMathElement.h was not generated; output from make below. I don't have time to figure out why right now, so I'm reverting the patch.

[leandro@navi ~/work/webkit] (master)$ make -j1
[  2%] Built target wtf_efl
[  9%] Built target javascriptcore_efl
[  9%] Built target jsc_efl
[  9%] Building CXX object WebCore/CMakeFiles/webcore_efl.dir/__/DerivedSources/JSMathMLElementWrapperFactory.cpp.o
/home/leandro/svn/webkit/build/DerivedSources/JSMathMLElementWrapperFactory.cpp:35:33: fatal error: JSMathMLMathElement.h: No such file or directory
compilation terminated.
make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/__/DerivedSources/JSMathMLElementWrapperFactory.cpp.o] Error 1
make[1]: *** [WebCore/CMakeFiles/webcore_efl.dir/all] Error 2
make: *** [all] Error 2
Comment 3 WebKit Commit Bot 2010-08-31 11:47:17 PDT
Comment on attachment 66077 [details]
ROLLOUT of r66484

Clearing flags on attachment: 66077

Committed r66513: <http://trac.webkit.org/changeset/66513>
Comment 4 WebKit Commit Bot 2010-08-31 11:47:23 PDT
All reviewed patches have been landed.  Closing bug.