Bug 44937

Summary:

Part 2: Unfork Chromium's FontPlatformDataMac.mm

Product:

WebKit

Reporter:

Jeremy Moskovich <playmobil>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

41148, 41398

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Jeremy Moskovich

Reported 2010-08-31 02:37:23 PDT

https://bugs.webkit.org/show_bug.cgi?id=41148 forks FontPlatformDataMac.mm for the Chromium port to enable cross-process font loading. This bug tracks unforking the file, https://bugs.webkit.org/show_bug.cgi?id=41398 was the first part of this.

Attachments
Patch (38.87 KB, patch) 2010-08-31 03:50 PDT, Jeremy Moskovich	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jeremy Moskovich

Comment 1 2010-08-31 03:50:49 PDT

Created attachment 66027 [details] Patch

Dimitri Glazkov (Google)

Comment 2 2010-08-31 15:41:44 PDT

Comment on attachment 66027 [details] Patch looks good. I wonder if we can somehow create a FontLoadingManager abstraction that allows having two different implementations of the same declaration? This would allow us to avoid ifdefs altogether. Not sure how at first glance, though.

WebKit Commit Bot

Comment 3 2010-08-31 21:49:57 PDT

Comment on attachment 66027 [details] Patch Clearing flags on attachment: 66027 Committed r66574: <http://trac.webkit.org/changeset/66574>

WebKit Commit Bot

Comment 4 2010-08-31 21:50:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.