Summary: | [EFL] Add setting API for enabling page cache. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | antognolli+webkit, commit-queue, kenneth, lucas.de.marchi, tonikitoo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Gyuyoung Kim
2010-08-30 23:36:41 PDT
Created attachment 66017 [details]
Patch
Comment on attachment 66017 [details] Patch > +Eina_Bool ewk_view_setting_page_cache_get(Evas_Object* o) why not page_cache_enabled? it returns a bool not a page cache! (In reply to comment #2) > (From update of attachment 66017 [details]) > > > +Eina_Bool ewk_view_setting_page_cache_get(Evas_Object* o) > > why not page_cache_enabled? it returns a bool not a page cache! The ewk_view_setting_page_cache_get() just returns if page cache feature is enabled or not. This method doesn't return page cache. In ewk_view.cpp, settings features like local_storage also have similar method. Eina_Bool ewk_view_setting_spatial_navigation_get(Evas_Object* o) { EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); return priv->settings.spatial_navigation; } Eina_Bool ewk_view_setting_local_storage_get(Evas_Object* o) { EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); return priv->settings.local_storage; } ... I add a doxyzen for the method. However, if the naming can make confusion, I change the name. What do you EFL guys think? (In reply to comment #4) > What do you EFL guys think? The naming is really not the best one, but as Gyuyoung told, it's following other ewk_view_setting functions. Maybe we should make a big change on all of them? Anyway, the patch looks good to me. Comment on attachment 66017 [details]
Patch
We can change the method names as a separate patch
Comment on attachment 66017 [details] Patch Clearing flags on attachment: 66017 Committed r67413: <http://trac.webkit.org/changeset/67413> All reviewed patches have been landed. Closing bug. |