Bug 44910

Summary: Add URLRequest API for WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2010-08-30 17:18:13 PDT
Add URLRequest API for WebKit2 .
Attachments
Patch (52.55 KB, patch)
2010-08-30 17:35 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-08-30 17:35:28 PDT
Created attachment 65982 [details] Patch
WebKit Review Bot
Comment 2 2010-08-30 17:43:29 PDT
Attachment 65982 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/Shared/WebURLRequest.cpp:10: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/Shared/qt/WebCoreArgumentCodersQt.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/API/C/cf/WKURLRequestCF.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/API/C/cf/WKURLRequestCF.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebCoreArgumentCoders.h:36: "WebCore/IntRect.h" already included at WebKit2/Shared/WebCoreArgumentCoders.h:35 [build/include] [4] WebKit2/UIProcess/API/C/WKAPICast.h:76: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:77: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:98: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:99: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKURLRequest.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/Shared/win/WebURLRequestWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/Shared/win/WebCoreArgumentCodersWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/Shared/qt/WebURLRequestQt.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 13 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-08-30 17:52:01 PDT
Landed in http://trac.webkit.org/changeset/66436.
Note You need to log in before you can comment on or make changes to this bug.