Bug 4491

Summary: DOM L2 Events tests using addEventListener broken
Product: WebKit Reporter: Curt Arnold <curt.arnold>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch for l2 events tests darin: review+

Curt Arnold
Reported 2005-08-17 08:49:47 PDT
The initial load the the DOM L2 Events tests in WebCore/layout-tests/html/level2/events were from a stale snapshot that did not include the changes resulting from the fix to http://www.w3.org/Bugs/Public/ show_bug.cgi?id=1137. The major observable change was that the second parameter to addEventListener should have been monitor.handleEvent and not monitor.
Attachments
Patch for l2 events tests (5.55 KB, patch)
2005-08-17 08:57 PDT, Curt Arnold
darin: review+
Curt Arnold
Comment 1 2005-08-17 08:57:34 PDT
Created attachment 3437 [details] Patch for l2 events tests The whitespace in the rendered tests have also been changed since the snapshot. This patch ignores the whitespace changes within the test scripts. The patch does not contain changes to the -expected files that may result from the test changes. Before committing, the -expected.txt's for the modified tests should be deleted and run-webkit-tests run twice (once to produce the -expected.txt and once to make sure they don't change).
Darin Adler
Comment 2 2005-08-17 11:24:14 PDT
*** Bug 4492 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.