Bug 44842

Summary: [CMake] Unify GENERATE_DOM_NAMES code
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, leandro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 44966    
Bug Blocks: 43906    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Patrick R. Gansterer
Reported 2010-08-29 11:43:29 PDT
see patch
Attachments
Patch (4.64 KB, patch)
2010-08-29 11:48 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (4.93 KB, patch)
2010-08-30 19:57 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (4.83 KB, patch)
2010-08-31 11:54 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-08-29 11:48:51 PDT
Created attachment 65859 [details] Patch
Leandro Pereira
Comment 2 2010-08-30 11:09:59 PDT
My only concern is linking to files related to disabled features. I know most files have preprocessor guards, but they'll be compiled and linked anyway. Since there are already tests for these features, I think it would be a good idea to enclose the GENERATE/append to sources list stuff inside these tests. Besides that, the patch looks fine to me.
Patrick R. Gansterer
Comment 3 2010-08-30 19:57:37 PDT
Created attachment 66004 [details] Patch Added IF(ENABLE_*)
WebKit Commit Bot
Comment 4 2010-08-31 07:59:59 PDT
Comment on attachment 66004 [details] Patch Clearing flags on attachment: 66004 Committed r66484: <http://trac.webkit.org/changeset/66484>
WebKit Commit Bot
Comment 5 2010-08-31 08:00:03 PDT
All reviewed patches have been landed. Closing bug.
Patrick R. Gansterer
Comment 6 2010-08-31 11:54:06 PDT
Created attachment 66080 [details] Patch fixed patch
Kenneth Rohde Christiansen
Comment 7 2010-08-31 12:04:58 PDT
Comment on attachment 66080 [details] Patch Let's hope this works then :-)
Patrick R. Gansterer
Comment 8 2010-08-31 14:11:47 PDT
reopen for commit queue
WebKit Commit Bot
Comment 9 2010-08-31 17:18:15 PDT
Comment on attachment 66080 [details] Patch Clearing flags on attachment: 66080 Committed r66556: <http://trac.webkit.org/changeset/66556>
WebKit Commit Bot
Comment 10 2010-08-31 17:18:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.