Bug 44777

Summary: Add an ENABLE define for purgeable memory support
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
add ENABLE_PURGEABLE_MEMORY none

Pratik Solanki
Reported 2010-08-27 09:52:36 PDT
We current enable purgeable memory in PurgeableBufferMac.cpp via this if check #ifndef BUILDING_ON_TIGER and we disable it in PurgeableBuffer.h by doing #if !OS(DARWIN) || defined(BUILDING_ON_TIGER) || PLATFORM(QT) || PLATFORM(GTK) It would be better to have an ENABLE macro that we can define in Platform.h so we could simply use something like #if ENABLE(PURGEABLE_MEMORY)
Attachments
add ENABLE_PURGEABLE_MEMORY (2.65 KB, patch)
2010-08-27 10:04 PDT, Pratik Solanki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2010-08-27 10:04:23 PDT
Created attachment 65727 [details] add ENABLE_PURGEABLE_MEMORY
WebKit Commit Bot
Comment 2 2010-08-28 00:59:19 PDT
Comment on attachment 65727 [details] add ENABLE_PURGEABLE_MEMORY Clearing flags on attachment: 65727 Committed r66301: <http://trac.webkit.org/changeset/66301>
WebKit Commit Bot
Comment 3 2010-08-28 00:59:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.