REGRESSION: some tests no longer painting

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Tony Chang]

After http://trac.webkit.org/changeset/66223, three tests started failing pixel tests on the Chromium bots:

  fast/canvas/canvas-as-image.html
  fast/canvas/canvas-as-image-incremental-repaint.html
  fast/gradients/generated-gradients.html

It seems that they're not painting the background at all.

I'm building webkit-mac to see if this also happens in Safari.

[Tony Chang]

Yup, repros in Safari too.

Here are the pixel results:

http://trac.webkit.org/export/66223/trunk/LayoutTests/platform/mac/fast/canvas/canvas-as-image-expected.png
http://build.chromium.org/buildbot/layout_test_results/webkit-rel-webkit-org/results/layout-test-results/fast/canvas/canvas-as-image-actual.png

http://trac.webkit.org/export/66223/trunk/LayoutTests/platform/mac/fast/canvas/canvas-as-image-incremental-repaint-expected.png
http://build.chromium.org/buildbot/layout_test_results/webkit-rel-webkit-org/results/layout-test-results/fast/canvas/canvas-as-image-incremental-repaint-actual.png

http://trac.webkit.org/export/66223/trunk/LayoutTests/platform/mac/fast/gradients/generated-gradients-expected.png
http://build.chromium.org/buildbot/layout_test_results/webkit-rel-webkit-org/results/layout-test-results/fast/gradients/generated-gradients-actual.png

[Nikolas Zimmermann]

Thanks for the report, I'll investigate tomorrow, about to go to bed.
Are you sure these are the only tests which are broken?

[Tony Chang]

(In reply to comment #2)
> Thanks for the report, I'll investigate tomorrow, about to go to bed.
> Are you sure these are the only tests which are broken?

These are the only layout tests that regressed on the chromium bots (across windows, mac and linux).  It's possible for there to be a test that chromium was already failing, in which case a regression would not be noticed.

[Tony Chang]

I suspect fast/canvas/webgl/css-webkit-canvas-repaint.html and fast/canvas/webgl/css-webkit-canvas.html are failing for the same reason.  I bet the pixel results were generated before r66223 was landed.

[Nikolas Zimmermann]

Created attachment 65813 [details]
Patch

[Dirk Schulze]

Comment on attachment 65813 [details]
Patch

r=me

[Nikolas Zimmermann]

Landed in r66299.

Tony, can you verify the regression is gone?
All tests you mentioned work again for me in Safari.

[WebKit Review Bot]

http://trac.webkit.org/changeset/66299 might have broken Qt Linux Release

[Tony Chang]

(In reply to comment #7)
> Landed in r66299.
> 
> Tony, can you verify the regression is gone?
> All tests you mentioned work again for me in Safari.

Yes, the regression is gone.  Thanks!