| Summary: | Try to make some xssAuditor tests less flakey. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ademar, simon.fraser, zimmermann | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andy Estes
2010-08-26 23:31:28 PDT
The following xssAuditor tests became flakey after http://trac.webkit.org/changeset/66156: * http/tests/security/xssAuditor/object-embed-tag-control-char.html * http/tests/security/xssAuditor/object-embed-tag-null-char.html * http/tests/security/xssAuditor/object-embed-tag.html r66156 changed how WebKit handles an <object> elements with a nested <embed>, such that the <embed> is rendered as fallback content if the <object> fails to load. Since the XSS Auditor prevents both the <object> and the <embed> from loading, there should be two lines of output in the expected results instead of one. However, since widgets sometimes begin loading on a post-layout timer, the test can finish before the timer fires. Calling notifyDone() on a timer is an easy way to solve this, although there might be a more elegant solution. Created attachment 65681 [details]
Patch
Created attachment 65683 [details]
Patch
Created attachment 65696 [details]
Patch
Okay, so instead of using a timer, I'm using postMessage() to communicate to the top window each time a beforeload event fires in the iframe. When the top window has seen a beforeload event from each widget in the iframe, it calls notifyDone(). This is more complicated but more reliable and less hacky. Skipped two tests, which always fail in r66210. Simon, do you have any feedback on why this was r-'ed? Do I just need to update the Skipped list before landing, or are there more substantial issues? Comment on attachment 65696 [details]
Patch
Sorry, mouse fumble. I meant to r+
(In reply to comment #8) > (From update of attachment 65696 [details]) > Sorry, mouse fumble. I meant to r+ Thanks :) Committed http://trac.webkit.org/changeset/66254. Revision r66254 cherry-picked into qtwebkit-2.1.x with commit 9d6baba <http://gitorious.org/webkit/qtwebkit/commit/9d6baba> |