Bug 44749

Summary:

Try to make some xssAuditor tests less flakey.

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, simon.fraser, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	simon.fraser: review+

Andy Estes

Reported 2010-08-26 23:31:28 PDT

Try to make some xssAuditor tests less flakey.

Attachments
Patch (4.86 KB, patch) 2010-08-26 23:55 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (6.94 KB, patch) 2010-08-27 00:19 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (14.38 KB, patch) 2010-08-27 03:38 PDT, Andy Estes	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2010-08-26 23:53:38 PDT

The following xssAuditor tests became flakey after http://trac.webkit.org/changeset/66156: * http/tests/security/xssAuditor/object-embed-tag-control-char.html * http/tests/security/xssAuditor/object-embed-tag-null-char.html * http/tests/security/xssAuditor/object-embed-tag.html r66156 changed how WebKit handles an <object> elements with a nested <embed>, such that the <embed> is rendered as fallback content if the <object> fails to load. Since the XSS Auditor prevents both the <object> and the <embed> from loading, there should be two lines of output in the expected results instead of one. However, since widgets sometimes begin loading on a post-layout timer, the test can finish before the timer fires. Calling notifyDone() on a timer is an easy way to solve this, although there might be a more elegant solution.

Andy Estes

Comment 2 2010-08-26 23:55:45 PDT

Created attachment 65681 [details] Patch

Andy Estes

Comment 3 2010-08-27 00:19:02 PDT

Created attachment 65683 [details] Patch

Andy Estes

Comment 4 2010-08-27 03:38:59 PDT

Created attachment 65696 [details] Patch

Andy Estes

Comment 5 2010-08-27 03:40:24 PDT

Okay, so instead of using a timer, I'm using postMessage() to communicate to the top window each time a beforeload event fires in the iframe. When the top window has seen a beforeload event from each widget in the iframe, it calls notifyDone(). This is more complicated but more reliable and less hacky.

Nikolas Zimmermann

Comment 6 2010-08-27 05:16:25 PDT

Skipped two tests, which always fail in r66210.

Andy Estes

Comment 7 2010-08-27 13:58:08 PDT

Simon, do you have any feedback on why this was r-'ed? Do I just need to update the Skipped list before landing, or are there more substantial issues?

Simon Fraser (smfr)

Comment 8 2010-08-27 14:00:28 PDT

Comment on attachment 65696 [details] Patch Sorry, mouse fumble. I meant to r+

Andy Estes

Comment 9 2010-08-27 14:04:49 PDT

(In reply to comment #8) > (From update of attachment 65696 [details]) > Sorry, mouse fumble. I meant to r+ Thanks :)

Andy Estes

Comment 10 2010-08-27 14:12:15 PDT

Committed http://trac.webkit.org/changeset/66254.

Ademar Reis

Comment 11 2011-05-11 12:49:58 PDT

Revision r66254 cherry-picked into qtwebkit-2.1.x with commit 9d6baba <http://gitorious.org/webkit/qtwebkit/commit/9d6baba>

Note You need to log in before you can comment on or make changes to this bug.