Bug 44741

Summary:

CanvasRenderingContext2D willDraw() should be didDraw()

Product:

WebKit

Reporter:

Vincent Scheib <scheib>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ariya.hidayat, commit-queue, hyatt, jamesr, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Vincent Scheib 2010-08-26 19:53:38 PDT

CanvasRenderingContext2D willDraw() should be didDraw()

Comment 1 Vincent Scheib 2010-08-26 20:04:36 PDT

Created attachment 65665 [details]
Patch

Comment 2 James Robinson 2010-08-26 22:56:43 PDT

I think this looks great. I assume it passes the fast/canvas and canvas/philip tests?

Comment 3 Ariya Hidayat 2010-08-26 23:08:27 PDT

Looks good indeed!

Comment 4 Vincent Scheib 2010-08-27 11:33:27 PDT

James, can you c+?

Passes fast/canvas and doesn't regress any of canvas/philip (which previously had 101 failures).

Comment 5 WebKit Commit Bot 2010-08-27 20:01:57 PDT

Comment on attachment 65665 [details]
Patch

Clearing flags on attachment: 65665

Committed r66295: <http://trac.webkit.org/changeset/66295>

Comment 6 WebKit Commit Bot 2010-08-27 20:02:02 PDT

All reviewed patches have been landed.  Closing bug.