Bug 44741

Summary: CanvasRenderingContext2D willDraw() should be didDraw()
Product: WebKit Reporter: Vincent Scheib <scheib>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat, commit-queue, hyatt, jamesr, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Vincent Scheib
Reported 2010-08-26 19:53:38 PDT
CanvasRenderingContext2D willDraw() should be didDraw()
Attachments
Patch (10.14 KB, patch)
2010-08-26 20:04 PDT, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vincent Scheib
Comment 1 2010-08-26 20:04:36 PDT
Created attachment 65665 [details] Patch
James Robinson
Comment 2 2010-08-26 22:56:43 PDT
I think this looks great. I assume it passes the fast/canvas and canvas/philip tests?
Ariya Hidayat
Comment 3 2010-08-26 23:08:27 PDT
Looks good indeed!
Vincent Scheib
Comment 4 2010-08-27 11:33:27 PDT
James, can you c+? Passes fast/canvas and doesn't regress any of canvas/philip (which previously had 101 failures).
WebKit Commit Bot
Comment 5 2010-08-27 20:01:57 PDT
Comment on attachment 65665 [details] Patch Clearing flags on attachment: 65665 Committed r66295: <http://trac.webkit.org/changeset/66295>
WebKit Commit Bot
Comment 6 2010-08-27 20:02:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.