Bug 44738

Summary:

SWIG wants explicit destructors for C++ DOM bindings

Product:

WebKit

Reporter:

Kevin Ollivier <kevino>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Add explicit destructor to C++ DOM bindings	kevino: review+

Description Kevin Ollivier 2010-08-26 18:20:25 PDT

The SWIG wrapper tool I'm using to generate Python bindings from the C++ DOM bindings requires an explicit destructor to be declared in order to ensure proper destruction. Without this, SWIG will generate (lots of) memory leak warnings.

Comment 1 Kevin Ollivier 2010-08-26 18:23:09 PDT

Created attachment 65656 [details]
Add explicit destructor to C++ DOM bindings

Comment 2 Kevin Ollivier 2010-08-28 16:07:27 PDT

Landed in r66316.

Comment 3 Nikolas Zimmermann 2010-08-28 16:10:37 PDT

Comment on attachment 65656 [details]
Add explicit destructor to C++ DOM bindings

LGTM, r=me.