Bug 44738

Summary: SWIG wants explicit destructors for C++ DOM bindings
Product: WebKit Reporter: Kevin Ollivier <kevino>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Wx
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Add explicit destructor to C++ DOM bindings kevino: review+

Kevin Ollivier
Reported 2010-08-26 18:20:25 PDT
The SWIG wrapper tool I'm using to generate Python bindings from the C++ DOM bindings requires an explicit destructor to be declared in order to ensure proper destruction. Without this, SWIG will generate (lots of) memory leak warnings.
Attachments
Add explicit destructor to C++ DOM bindings (1.16 KB, patch)
2010-08-26 18:23 PDT, Kevin Ollivier 		kevino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin Ollivier
Comment 1 2010-08-26 18:23:09 PDT
Created attachment 65656 [details] Add explicit destructor to C++ DOM bindings
Kevin Ollivier
Comment 2 2010-08-28 16:07:27 PDT
Landed in r66316.
Nikolas Zimmermann
Comment 3 2010-08-28 16:10:37 PDT
Comment on attachment 65656 [details] Add explicit destructor to C++ DOM bindings LGTM, r=me.
Note You need to log in before you can comment on or make changes to this bug.