Bug 44735

Summary: Clean up dtoa.cpp
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch sam: review+

Gavin Barraclough
Reported 2010-08-26 17:28:48 PDT
Remove unused & unmaintained code paths, reformat code to match coding standard & use platform #defines from Platform.h directly.
Attachments
The patch (39.76 KB, patch)
2010-08-26 17:30 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-08-26 17:30:32 PDT
Created attachment 65650 [details] The patch
James Robinson
Comment 2 2010-08-26 18:56:27 PDT
This broke the compile on windows. Is anyone fixing it, or should we roll out?
Gavin Barraclough
Comment 3 2010-08-26 20:35:34 PDT
fixed in 66163
Alexey Proskuryakov
Comment 4 2010-08-27 10:32:09 PDT
+/* Please send bug reports to David M. Gay (dmg at acm dot org, + * with " at " changed at "@" and " dot " changed to "."). */ Really? :-)
Gavin Barraclough
Comment 5 2010-08-31 20:17:03 PDT
(In reply to comment #4) > +/* Please send bug reports to David M. Gay (dmg at acm dot org, > + * with " at " changed at "@" and " dot " changed to "."). */ > > Really? :-) That's a very good question. :-) I was patching a bunch of changes back from an updated version, and wanted to obfuscate this email address (as it is in now in the latest version of the original source). But the comment in context is probably no longer a great suggestion. Will reword to give David the credit for his work & us the blame for any bugs we've introduced in a later patch. cheers, G.
Note You need to log in before you can comment on or make changes to this bug.