Bug 44715 – maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac

• Component: WebKit2
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

To reproduce:

1. Go to http://maps.google.com/
2. Hover over the map
3. Scroll using the trackpad

The page flips upside down while the map zooms in.

[Adam Roben (:aroben)]

(You'll also run into bug 44716.)

[Adam Roben (:aroben)]

<rdar://problem/8360139>

[Simon Fraser (smfr)]

Created attachment 67428 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 67428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67428&action=prettypatch

It might be useful to describe somewhere how calling -setGeometryFlipped: ends up flipping the layers.

r=me

[Early Warning System Bot]

Attachment 67428 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3914432

[Eric Seidel (no email)]

Attachment 67428 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3926417

[WebKit Review Bot]

Attachment 67428 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3942413

[Simon Fraser (smfr)]

Comment on attachment 67428 [details]
Patch

I'm going to upload a better version of this patch.

[Simon Fraser (smfr)]

Created attachment 67704 [details]
Patch

[Eric Seidel (no email)]

Attachment 67704 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4014020

[Adam Roben (:aroben)]

Comment on attachment 67704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67704&action=prettypatch

> WebCore/platform/graphics/mac/GraphicsLayerCA.mm:2220
> -GraphicsLayer::CompositingCoordinatesOrientation GraphicsLayerCA::defaultContentsOrientation() const
> +GraphicsLayerCA::CompositingCoordinatesOrientation GraphicsLayerCA::defaultContentsOrientation() const
I don't see anywhere where you add defaultContentsOrientation() to GraphicsLayerCA's class declaration. Will this break the build?

> WebCore/platform/graphics/win/GraphicsLayerCACF.cpp:457
> +    // FIXME: need this?
> +//    if (useTiledLayer) {
> +//        if (GraphicsLayer::compositingCoordinatesOrientation() == GraphicsLayer::CompositingCoordinatesBottomUp)
> +//            m_layer->setContentsGravity(WKCACFLayer::BottomLeft);
> +//        else
> +//            m_layer->setContentsGravity(WKCACFLayer::TopLeft);
> +//    }
Did you mean to leave this in?

r=me

[Early Warning System Bot]

Attachment 67704 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4072016

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/67576

[WebKit Review Bot]

http://trac.webkit.org/changeset/67576 might have broken Chromium Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/67576
http://trac.webkit.org/changeset/67574

[Eric Seidel (no email)]

Could this be causing the image load failure seen in bug 45875?  I kinda doubt it, but I'm grasping at straws here.

[Simon Fraser (smfr)]

Extremely unlikely.