Bug 44695

Summary:

Add index insertion support to IndexedDB.

Product:

WebKit

Reporter:

Jeremy Orlow <jorlow>

Component:

New Bugs

Assignee:

Jeremy Orlow <jorlow>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, andreip, bulach, dglazkov, eric, fishd, steveblock, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	steveblock: review+

Jeremy Orlow

Reported 2010-08-26 10:38:34 PDT

Add index insertion support to IndexedDB.

Attachments
Patch (31.36 KB, patch) 2010-08-26 10:42 PDT, Jeremy Orlow	no flags	Details Formatted Diff Diff
Patch (31.56 KB, patch) 2010-08-31 06:55 PDT, Jeremy Orlow	no flags	Details Formatted Diff Diff
Patch (31.56 KB, patch) 2010-09-03 06:24 PDT, Jeremy Orlow	steveblock: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jeremy Orlow

Comment 1 2010-08-26 10:40:55 PDT

+ Darin to look at the asserts I've added to WebKit.

Jeremy Orlow

Comment 2 2010-08-26 10:42:12 PDT

Created attachment 65579 [details] Patch

Jeremy Orlow

Comment 3 2010-08-31 06:55:01 PDT

Created attachment 66046 [details] Patch

Darin Fisher (:fishd, Google)

Comment 4 2010-08-31 09:52:51 PDT

Comment on attachment 66046 [details] Patch > +++ b/WebKit/chromium/public/WebVector.h > @@ -115,8 +115,16 @@ public: > size_t size() const { return m_size; } > bool isEmpty() const { return !m_size; } > > - T& operator[](size_t i) { return m_ptr[i]; } > - const T& operator[](size_t i) const { return m_ptr[i]; } > + T& operator[](size_t i) > + { > + WEBKIT_ASSERT(i < m_size); > + return m_ptr[i]; > + } > + const T& operator[](size_t i) const > + { > + WEBKIT_ASSERT(i < m_size); > + return m_ptr[i]; > + } > > T* data() { return m_ptr; } > const T* data() const { return m_ptr; } LGTM for the above change.

Jeremy Orlow

Comment 5 2010-09-02 10:41:47 PDT

Comment on attachment 66046 [details] Patch Steve did a review with me on my computer. His 2 comments: > doDelete(sqliteDatabase(), "DELETE FROM IndexData WHERE indexId IN (SELECT id FROM Indexes WHERE objectStoreId = ?)", objectStore->id()); Index on the indexID. ? static void putObjectStoreData(SQLiteDatabase& db, bool isExistingValue, IDBKey* key, SerializedScriptValue* value, int64_t objectStoreId, int64_t* dataRowId) get rid of isExistingValue..just key off of dataRowId

Jeremy Orlow

Comment 6 2010-09-03 06:24:20 PDT

Created attachment 66486 [details] Patch

WebKit Review Bot

Comment 7 2010-09-03 06:55:55 PDT

Attachment 66486 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3948085

Steve Block

Comment 8 2010-09-03 06:59:02 PDT

Comment on attachment 66486 [details] Patch IDBObjectStoreBackendImpl.cpp:128 Oops! r=me, subject to typo fix

Jeremy Orlow

Comment 9 2010-09-05 09:29:15 PDT

Will land after next webkit roll. Thanks!