Bug 44658

Summary: [EFL] Need to check LibSoup version
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, leandro, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
patch
leandro: review-
Patch none

Ryuan Choi
Reported 2010-08-25 19:39:20 PDT
FIND_PACKAGE(LibSoup2 2.28.2 REQUIRED) above command in cmake/OptionEfl.cmake looks not check 2.28.2 but we need to check version of LibSoup. When I used CMake 2.8.2 and LibSoup 2.28.1, I got a build break because of missing new feature of libSoup. but cmake passed configuration without error.
Attachments
Patch (1.05 KB, patch)
2010-08-25 19:45 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
patch (1.93 KB, patch)
2010-08-26 11:24 PDT, Leandro Pereira 		leandro: review-
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2010-09-01 03:55 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2010-08-25 19:45:02 PDT
Created attachment 65518 [details] Patch
Rafael Antognolli
Comment 2 2010-08-26 06:54:41 PDT
(In reply to comment #1) > Created an attachment (id=65518) [details] > Patch Hi Ryuan, I think this is a problem in cmake/FindLibSoup2.cmake, that's probably not checking for the libsoup version correctly. I think it's better to fix it than doing this workaround, though I'm not good on cmake and couldn't find the bug on a quick look. I'm cc'ing Leandro, maybe he can help you with this.
Leandro Pereira
Comment 3 2010-08-26 11:24:50 PDT
Created attachment 65586 [details] patch I would like to see a patch more like this one, fixing FindLibSoup2.cmake, but if possible, checking the version without having to define a variable.
Ryuan Choi
Comment 4 2010-08-27 07:47:08 PDT
(In reply to comment #3) > Created an attachment (id=65586) [details] > patch > > I would like to see a patch more like this one, fixing FindLibSoup2.cmake, but if possible, checking the version without having to define a variable. It looks quite better.
Ryuan Choi
Comment 5 2010-09-01 03:55:42 PDT
Created attachment 66195 [details] Patch
Ryuan Choi
Comment 6 2010-09-01 03:57:09 PDT
(In reply to comment #5) > Created an attachment (id=66195) [details] > Patch I tried like attachment. this patch doesn't define a variable.
Antonio Gomes
Comment 7 2010-09-01 07:19:02 PDT
(In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=66195) [details] [details] > > Patch > > I tried like attachment. > this patch doesn't define a variable. cmake guys?
Leandro Pereira
Comment 8 2010-09-01 08:00:08 PDT
(In reply to comment #7) > > > > I tried like attachment. > > this patch doesn't define a variable. > > cmake guys? LGTM
Antonio Gomes
Comment 9 2010-09-01 09:09:46 PDT
Comment on attachment 66195 [details] Patch I trust you guys.
WebKit Commit Bot
Comment 10 2010-09-01 09:34:49 PDT
Comment on attachment 66195 [details] Patch Clearing flags on attachment: 66195 Committed r66609: <http://trac.webkit.org/changeset/66609>
WebKit Commit Bot
Comment 11 2010-09-01 09:34:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.