Bug 44638

Summary: Add updated versions of v8 tests to webkit source tree
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Enhancement CC: barraclough, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks barraclough: review-, commit-queue: commit-queue-

Michael Saboff
Reported 2010-08-25 15:04:46 PDT
The current WebKit source tree has V8 version 4 benchmark tests that work with the sunspider framework. There are now version 5 and 6 of the V8 tests. These newer versions should be added.
Attachments
Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks (863.67 KB, patch)
2010-08-25 16:59 PDT, Michael Saboff 		barraclough: review-
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2010-08-25 16:59:06 PDT
Created attachment 65501 [details] Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks Note that these javascript files do not conform to the WebKit standard. The copyrights for each of these files is the same as the corresponding vers 4 files.
WebKit Review Bot
Comment 2 2010-08-25 17:06:35 PDT
Attachment 65501 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 Last 3072 characters of output: y-boyer.js:3303: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3310: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3317: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3324: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3331: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3338: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3345: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3352: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3412: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3413: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3415: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3417: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3422: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3423: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3425: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-earley-boyer.js:3427: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:456: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:475: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:480: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:492: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:536: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:537: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:538: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:539: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:542: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:577: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:755: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-crypto.js:1131: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-raytrace.js:652: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-raytrace.js:654: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-raytrace.js:656: Line contains tab character. [whitespace/tab] [5] SunSpider/tests/v8-v6/v8-raytrace.js:658: Line contains tab character. [whitespace/tab] [5] Total errors found: 1574 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2010-08-26 10:28:41 PDT
Comment on attachment 65501 [details] Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks Rejecting patch 65501 from commit-queue. msaboff@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 4 2010-08-27 06:18:45 PDT
Comment on attachment 65501 [details] Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks Rejecting patch 65501 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20842 test cases. http/tests/security/xssAuditor/object-embed-tag.html -> failed Exiting early after 1 failures. 20546 tests run. 532.07s total testing time 20545 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 28 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3867024
Gavin Barraclough
Comment 5 2010-08-27 16:56:34 PDT
Comment on attachment 65501 [details] Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks This commit fails because the file contain tabs, we'll have to replace these with spaces.
Gavin Barraclough
Comment 6 2010-08-27 17:07:27 PDT
Ooops, no, just needed a property setting. Landed in r66281.
Note You need to log in before you can comment on or make changes to this bug.