Summary: | Add updated versions of v8 tests to webkit source tree | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | barraclough, commit-queue, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Michael Saboff
2010-08-25 15:04:46 PDT
Created attachment 65501 [details]
Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks
Note that these javascript files do not conform to the WebKit standard.
The copyrights for each of these files is the same as the corresponding vers 4 files.
Attachment 65501 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Last 3072 characters of output:
y-boyer.js:3303: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3310: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3317: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3324: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3331: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3338: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3345: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3352: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3412: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3413: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3415: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3417: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3422: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3423: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3425: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-earley-boyer.js:3427: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:456: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:475: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:480: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:492: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:536: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:537: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:538: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:539: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:542: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:577: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:755: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-crypto.js:1131: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-raytrace.js:652: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-raytrace.js:654: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-raytrace.js:656: Line contains tab character. [whitespace/tab] [5]
SunSpider/tests/v8-v6/v8-raytrace.js:658: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1574 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 65501 [details] Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks Rejecting patch 65501 from commit-queue. msaboff@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 65501 [details] Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks Rejecting patch 65501 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20842 test cases. http/tests/security/xssAuditor/object-embed-tag.html -> failed Exiting early after 1 failures. 20546 tests run. 532.07s total testing time 20545 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 28 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3867024 Comment on attachment 65501 [details]
Patch adding V8 vers 5 and V8 vers 6 javascript benchmarks
This commit fails because the file contain tabs, we'll have to replace these with spaces.
|