Bug 44618

Summary: [Qt] Replace QLibrary("libgdk-x11-2.0.so.0") with QLibrary("libgdk-x11-2.0", 0)
Product: WebKit Reporter: Girish Ramakrishnan <girish>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
patch ariya.hidayat: review+, commit-queue: commit-queue-

Girish Ramakrishnan
Reported 2010-08-25 09:52:58 PDT
According to Harald Fernengel, this is better.
Attachments
patch (1.53 KB, patch)
2010-08-25 09:54 PDT, Girish Ramakrishnan 		ariya.hidayat: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Girish Ramakrishnan
Comment 1 2010-08-25 09:54:18 PDT
Created attachment 65430 [details] patch
Andreas Kling
Comment 2 2010-08-25 11:20:44 PDT
Comment on attachment 65430 [details] patch LGTM, didn't know we had this API. :)
Ariya Hidayat
Comment 3 2010-08-25 12:03:28 PDT
Comment on attachment 65430 [details] patch LGTM.r+
WebKit Commit Bot
Comment 4 2010-08-25 15:39:37 PDT
Comment on attachment 65430 [details] patch Rejecting patch 65430 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20928 test cases. media/video-played-collapse.html -> failed Exiting early after 1 failures. 17270 tests run. 380.72s total testing time 17269 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 33 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3796353
Girish Ramakrishnan
Comment 5 2010-08-26 00:34:19 PDT
Landed manually in r66084.
Note You need to log in before you can comment on or make changes to this bug.