Bug 44591

Summary: Deploy adoptPtr to WebCore/loader
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Adam Barth
Reported 2010-08-25 00:45:31 PDT
Deploy adoptPtr to WebCore/loader
Attachments
Patch (19.45 KB, patch)
2010-08-25 00:49 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.40 KB, patch)
2010-08-25 09:47 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.42 KB, patch)
2010-08-25 11:40 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-08-25 00:49:12 PDT
Created attachment 65382 [details] Patch
WebKit Review Bot
Comment 2 2010-08-25 02:01:42 PDT
Attachment 65382 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3805075
Adam Barth
Comment 3 2010-08-25 09:47:53 PDT
Created attachment 65429 [details] Patch for landing
Darin Adler
Comment 4 2010-08-25 10:17:00 PDT
Comment on attachment 65429 [details] Patch for landing I don't think that using adoptPtr on classes derived from CachedResource is helpful until we figure out the ownership approach. Adding adoptPtr/leakPtr to call sites doesn't do a lot of harm, but I also don't think it does much good. Since no icon database is ever deleted, it is too bad we are compiling code that calls the icon database destructor. It might be better for us to come up with a different way to handle immortal objects, rather than using OwnPtr which will compile in never-called code paths that destroy the object. I suggest omitting the IconDatabase changes.
Adam Barth
Comment 5 2010-08-25 11:40:01 PDT
Created attachment 65451 [details] Patch for landing
WebKit Commit Bot
Comment 6 2010-08-25 19:32:14 PDT
Comment on attachment 65451 [details] Patch for landing Rejecting patch 65451 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20823 test cases. svg/dom/SVGScriptElement/script-set-href.svg -> failed Exiting early after 1 failures. 18347 tests run. 542.96s total testing time 18346 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 26 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3740638
Eric Seidel (no email)
Comment 7 2010-08-25 23:20:39 PDT
Comment on attachment 65451 [details] Patch for landing Another flaky test.
WebKit Commit Bot
Comment 8 2010-08-26 00:28:17 PDT
Comment on attachment 65451 [details] Patch for landing Clearing flags on attachment: 65451 Committed r66083: <http://trac.webkit.org/changeset/66083>
WebKit Commit Bot
Comment 9 2010-08-26 00:28:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.