Bug 44577

Summary:

HTMLMediaElement.canPlayType must be case insensitive for MIME type.

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, jer.noble

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

51249

Attachments:

Description	Flags
proposed patch	ap: review+

Description Eric Carlson 2010-08-24 19:36:39 PDT

According to RFC 1521 the MIME type, subtype, and parameter names are not case sensitive, so canPlayType() must be case insensitive for the type and "codecs" parameter name.

Comment 1 Eric Carlson 2010-08-24 21:48:00 PDT

Created attachment 65367 [details]
proposed patch

Comment 2 Alexey Proskuryakov 2010-08-25 10:03:45 PDT

Comment on attachment 65367 [details]
proposed patch

Would it make sense to add subtests, as opposed to changing them?

r=me either way.

Comment 3 Eric Carlson 2010-08-25 10:55:46 PDT

(In reply to comment #2)
> (From update of attachment 65367 [details])
> Would it make sense to add subtests, as opposed to changing them?
> 
I left it with just changing existing tests as the media tests already take a significant amount of time to run.

> r=me either way.
>
Thanks!

http://trac.webkit.org/changeset/66023

Comment 4 Ademar Reis 2011-01-24 12:20:48 PST

Revision r66023 cherry-picked into qtwebkit-2.2 with commit c7a1663 <http://gitorious.org/webkit/qtwebkit/commit/c7a1663>