Bug 44577

Summary: HTMLMediaElement.canPlayType must be case insensitive for MIME type.
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 51249    
Attachments:
Description Flags
proposed patch ap: review+

Eric Carlson
Reported 2010-08-24 19:36:39 PDT
According to RFC 1521 the MIME type, subtype, and parameter names are not case sensitive, so canPlayType() must be case insensitive for the type and "codecs" parameter name.
Attachments
proposed patch (7.97 KB, patch)
2010-08-24 21:48 PDT, Eric Carlson 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2010-08-24 21:48:00 PDT
Created attachment 65367 [details] proposed patch
Alexey Proskuryakov
Comment 2 2010-08-25 10:03:45 PDT
Comment on attachment 65367 [details] proposed patch Would it make sense to add subtests, as opposed to changing them? r=me either way.
Eric Carlson
Comment 3 2010-08-25 10:55:46 PDT
(In reply to comment #2) > (From update of attachment 65367 [details]) > Would it make sense to add subtests, as opposed to changing them? > I left it with just changing existing tests as the media tests already take a significant amount of time to run. > r=me either way. > Thanks! http://trac.webkit.org/changeset/66023
Ademar Reis
Comment 4 2011-01-24 12:20:48 PST
Revision r66023 cherry-picked into qtwebkit-2.2 with commit c7a1663 <http://gitorious.org/webkit/qtwebkit/commit/c7a1663>
Note You need to log in before you can comment on or make changes to this bug.