Bug 44561

Summary:

[Cairo][REGRESSION] Overzealous Use of Gtk-Specific Smart Pointers Breaks other Builds

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Create cairo specializations for PassRefPtr/RefPtr use	none

Brent Fulgham

Reported 2010-08-24 16:14:46 PDT

Changes to the ImageCairo.cpp class (see @r65530) involved changes that used smart pointers on various Cairo data types. While I applaud this concept, the implementor made the unfortunate decision to use a GPtr-based implementation, rather than building on existing platform-agnostic WebKit smart pointer types. Since the ImageCairo class is not a Gtk-specific class, this violation of API separation creates build problems. As far as I can tell, the specific instances in ImageCairo.cpp where GPtr-based smart pointers are used could be replaced with a non-Gtk-specific implementation. This issue will make this change to resolve this build regression.

Attachments
Create cairo specializations for PassRefPtr/RefPtr use (3.08 KB, patch) 2010-08-25 09:21 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2010-08-25 00:51:36 PDT

*** This bug has been marked as a duplicate of bug 44354 ***

Martin Robinson

Comment 2 2010-08-25 00:52:05 PDT

I have a patch for this issue here: https://bugs.webkit.org/show_bug.cgi?id=44354 It is simply waiting on a review.

Brent Fulgham

Comment 3 2010-08-25 09:21:22 PDT

Created attachment 65428 [details] Create cairo specializations for PassRefPtr/RefPtr use A proposed update that provides Cairo-specific specializations for the [Pass]RefPtr templates.

Note You need to log in before you can comment on or make changes to this bug.