Bug 44555

Summary: Single Entry RegExp Cache Hurts Performance
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch to remove single entry regexp cache. none

Michael Saboff
Reported 2010-08-24 14:53:34 PDT
The single entry regular expression cache designed to help Dromaeo regexp performance hurts current SunSpider and Dromaeo performance. The Dromaeo benchmark has been changed with some randomization to the regexp test so that a single entry cache provides no benefit. In fact the cache hurts the current regexp test by about .85%. The RE cache hurts the Dromaeo javascript tests by 1.4% and SunSpider by .9%. There was no perceived impact on v8 (version 4) tests. It is proposed that the single entry RE cache be removed. <rdar://problem/8197541>
Attachments
Patch to remove single entry regexp cache. (3.18 KB, patch)
2010-08-24 15:37 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2010-08-24 15:37:19 PDT
Created attachment 65336 [details] Patch to remove single entry regexp cache.
Geoffrey Garen
Comment 2 2010-08-25 11:17:35 PDT
Comment on attachment 65336 [details] Patch to remove single entry regexp cache. Moving into the commit queue since Michael doesn't have commit access yet.
WebKit Commit Bot
Comment 3 2010-08-25 11:55:58 PDT
Comment on attachment 65336 [details] Patch to remove single entry regexp cache. Clearing flags on attachment: 65336 Committed r66031: <http://trac.webkit.org/changeset/66031>
WebKit Commit Bot
Comment 4 2010-08-25 11:56:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.