Bug 44538

Summary:

Web Inspector: allow re-attaching front-end.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, eric, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change.	joepeck: review+, joepeck: commit-queue-

Pavel Feldman

Reported 2010-08-24 10:57:06 PDT

Sometimes we'd like to re-attach existing front-end to the inspector controller. For example it happens when we reload extension being debugged. Add a simple check into the front-end handshake that would clean it up in such cases.

Attachments
[PATCH] Proposed change. (2.45 KB, patch) 2010-08-24 10:58 PDT, Pavel Feldman	joepeck: review+ joepeck: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-08-24 10:58:38 PDT

Created attachment 65296 [details] [PATCH] Proposed change.

Joseph Pecoraro

Comment 2 2010-08-24 11:11:52 PDT

Comment on attachment 65296 [details] [PATCH] Proposed change. > diff WebCore/inspector/Inspector.idl > module core { > interface [Conditional=INSPECTOR] Inspector { > + [notify] void frontendConnected(); > [notify] void addConsoleMessage(out Object messageObj); > [notify] void addRecordToTimeline(out Object record); These were alphabetical. Might be nice to follow suit with this one. > diff WebCore/inspector/front-end/inspector.js > +WebInspector.frontendConnected = function() > +{ > + // Reset front-end if it is connected to the backend second time. Grammar: to the backend "a" second time r=me with those fixes.

Eric Seidel (no email)

Comment 3 2010-12-20 22:30:55 PST

Was this landed already?

Note You need to log in before you can comment on or make changes to this bug.