Bug 44534

Summary: [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, gustavo, webkit.review.bot, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch for this issue
none
Fixes related to use of GdkEvent none

Martin Robinson
Reported 2010-08-24 10:23:07 PDT
GTK3 events should be created with gdk_event_new instead of allocated on the stack.
Attachments
Patch for this issue (15.81 KB, patch)
2010-08-24 10:41 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Fixes related to use of GdkEvent (5.52 KB, patch)
2010-08-24 12:17 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-08-24 10:41:22 PDT
Created attachment 65294 [details] Patch for this issue
Xan Lopez
Comment 2 2010-08-24 10:43:41 PDT
Comment on attachment 65294 [details] Patch for this issue r=me
Martin Robinson
Comment 3 2010-08-24 11:08:23 PDT
Comment on attachment 65294 [details] Patch for this issue Clearing flags on attachment: 65294 Committed r65915: <http://trac.webkit.org/changeset/65915>
Martin Robinson
Comment 4 2010-08-24 11:08:27 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-08-24 11:49:28 PDT
http://trac.webkit.org/changeset/65915 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65913 http://trac.webkit.org/changeset/65914 http://trac.webkit.org/changeset/65915
Martin Robinson
Comment 6 2010-08-24 12:17:13 PDT
Created attachment 65305 [details] Fixes related to use of GdkEvent
WebKit Review Bot
Comment 7 2010-08-24 12:22:24 PDT
Attachment 65305 [details] did not build on gtk: Build output: http://queues.webkit.org/results/3748626
Xan Lopez
Comment 8 2010-08-24 12:23:02 PDT
Comment on attachment 65305 [details] Fixes related to use of GdkEvent OK, good catch.
Martin Robinson
Comment 9 2010-08-24 12:26:49 PDT
Comment on attachment 65305 [details] Fixes related to use of GdkEvent Clearing flags on attachment: 65305 Committed r65922: <http://trac.webkit.org/changeset/65922>
Martin Robinson
Comment 10 2010-08-24 12:26:55 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 11 2010-08-24 13:09:02 PDT
http://trac.webkit.org/changeset/65922 might have broken Leopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.