Bug 44522

Summary: IndexedDB needs to manually delete all objectStore data and indexes
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andreip, bulach, eric, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch steveblock: review+

Jeremy Orlow
Reported 2010-08-24 06:44:02 PDT
IndexedDB needs to manually delete all objectStore data and indexes
Attachments
Patch (18.35 KB, patch)
2010-08-24 06:59 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (18.63 KB, patch)
2010-08-24 08:18 PDT, Jeremy Orlow 		steveblock: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-08-24 06:59:54 PDT
Created attachment 65270 [details] Patch
Andrei Popescu
Comment 2 2010-08-24 07:25:02 PDT
> doDelete(sqliteDatabase(), "DELETE FROM ObjectStores WHERE id = ?", objectStore->id()); > doDelete(sqliteDatabase(), "DELETE FROM ObjectStoreData WHERE objectStoreId = ?", objectStore->id()); > doDelete(sqliteDatabase(), "DELETE FROM Indexes WHERE objectStoreId = ?", objectStore->id()); I think you should start a SQL transaction to run these in, as we want them to succeed or fail together. Going forward, these will execute in the setVersion() transaction but, for now, I think we should have a these in their own transaction. LGTM otherwise.
Jeremy Orlow
Comment 3 2010-08-24 08:18:20 PDT
Created attachment 65274 [details] Patch
Andrei Popescu
Comment 4 2010-08-24 08:25:28 PDT
LGTM
Steve Block
Comment 5 2010-08-24 08:30:21 PDT
Comment on attachment 65274 [details] Patch r=me
Jeremy Orlow
Comment 6 2010-08-24 08:44:27 PDT
Committed r65902: <http://trac.webkit.org/changeset/65902>
WebKit Review Bot
Comment 7 2010-08-24 09:25:03 PDT
http://trac.webkit.org/changeset/65902 might have broken Leopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.