[EFL] Url of HistoryItem was broken for special character like korean

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

visiting any site after entered below site, url of history item was broken.

http://ko.wikipedia.org/wiki/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EB%8C%80%EB%AC%B8 (http://ko.wikipedia.org/wiki/위키백과:대문)

It's because of simple implementation of ewk_fram_view_state_save.
but I think that we can remove setTitle and setURLString in ewk_frame_view_state_save.

I checked like below. and I found that before and after was same.

void ewk_frame_view_state_save(Evas_Object *o, WebCore::HistoryItem* item)
{
    const char *title = ewk_frame_title_get(o);
    const char *uri = ewk_frame_uri_get(o);

    printf("%s\n", item->title().utf8().data());
    printf("=>%s\n", title);
    printf("%s\n", item->urlString().utf8().data());
    printf("=>%s\n", uri);
    item->setTitle(WTF::String::fromUTF8(title));
    item->setURLString(WTF::String::fromUTF8(uri));

    evas_object_smart_callback_call(o, "state,save", 0);
}

[Ryuan Choi]

Created attachment 65225 [details]
Patch

[Rafael Antognolli]

Hi Ryuan,

Can you detail more this problem? I just checked the url of this site on history (using Eve as test application), and it seems to work fine.

Is the url of this korean site that is broken? Or other urls? (actually, everything seems to be ok here)

[Ryuan Choi]

(In reply to comment #2)
> Hi Ryuan,
> 
> Can you detail more this problem? I just checked the url of this site on history (using Eve as test application), and it seems to work fine.
> 
> Is the url of this korean site that is broken? Or other urls? (actually, everything seems to be ok here)

yes. It's hard to reproduce.

below is reproduce step.

1. launch like below
 EWeblauncher http://www.wikipedia.org
2. click link '한국어' and then you can see some korean site which is http://ko.wikipedia.org/wiki/위키백과:대문
3. click a one of link to move other page(I use English in left menu)
4. press F1 to move back.

I found that latest webkit crashes and previous version just print different page which explain broken link as korean.

I'll investigate why crash. but we'd better to remove this code.
It looks not required and buggy.

[Adam Barth]

Comment on attachment 65225 [details]
Patch

ok

[WebKit Commit Bot]

Comment on attachment 65225 [details]
Patch

Clearing flags on attachment: 65225

Committed r66451: <http://trac.webkit.org/changeset/66451>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.