Summary: | Suffix for CSS alphabetic list style types should fallback to decimal for ordinals outside of their representable range | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, bdakin, darin, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Daniel Bates
2010-08-23 21:39:37 PDT
Created attachment 65212 [details] Patch with test case Moved the bounds checking code from the separate list style functions to effectiveListMarkerType() so that we can re-use this code for determining the fallback suffix style (i.e. decimal). I am open to name suggestions for the function effectiveListMarkerType. We need DRT support to test the actual suffix, see bug #44489 for more details. Comment on attachment 65212 [details] Patch with test case > + EListStyleType effectiveType = type; I'd prefer if we just used return statements rather than a local variable that we alter and then fall through to a shared return statement. > + // If the list-style-type, say hebrew, cannot represent |value| because it's outside > + // its ordinal range then we fallback to some list style that can represent |value|. The word "fallback" is a noun or adjective. You want the verb phrase "fall back". I don't think the words "say hebrew" help much here. (In reply to comment #2) > (From update of attachment 65212 [details]) > > + EListStyleType effectiveType = type; > > I'd prefer if we just used return statements rather than a local variable that we alter and then fall through to a shared return statement. > Will change. > > + // If the list-style-type, say hebrew, cannot represent |value| because it's outside > > + // its ordinal range then we fallback to some list style that can represent |value|. > > The word "fallback" is a noun or adjective. You want the verb phrase "fall back". > Will change. > I don't think the words "say hebrew" help much here. Will remove from comment. Committed r65967: <http://trac.webkit.org/changeset/65967> http://trac.webkit.org/changeset/65970 might have broken SnowLeopard Intel Release (Tests) |