Bug 44453

Summary: Add missing methods at ResourceHandleWin
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 43712    
Attachments:
Description Flags
Patch
aroben: review+, aroben: commit-queue-
Patch
aroben: review+, aroben: commit-queue+
Patch none

Patrick R. Gansterer
Reported 2010-08-23 13:13:57 PDT
see patch
Attachments
Patch (1.72 KB, patch)
2010-08-23 13:16 PDT, Patrick R. Gansterer 		aroben: review+
aroben: commit-queue-
DetailsFormatted DiffDiff
Patch (1.71 KB, patch)
2010-08-24 06:42 PDT, Patrick R. Gansterer 		aroben: review+
aroben: commit-queue+
DetailsFormatted DiffDiff
Patch (1.71 KB, patch)
2010-08-24 07:12 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-08-23 13:16:35 PDT
Created attachment 65158 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-08-24 06:40:06 PDT
Comment on attachment 65158 [details] Patch > +bool ResourceHandle::willLoadFromCache(ResourceRequest& req, Frame*) Unused (and strangely abbreviated) parameter name here. r=me
Patrick R. Gansterer
Comment 3 2010-08-24 06:42:49 PDT
Created attachment 65267 [details] Patch
Adam Roben (:aroben)
Comment 4 2010-08-24 06:56:02 PDT
Comment on attachment 65267 [details] Patch r=me
Patrick R. Gansterer
Comment 5 2010-08-24 07:12:07 PDT
Created attachment 65272 [details] Patch Once again, sorry for the typo.
WebKit Commit Bot
Comment 6 2010-08-25 01:07:21 PDT
Comment on attachment 65272 [details] Patch Clearing flags on attachment: 65272 Committed r65994: <http://trac.webkit.org/changeset/65994>
WebKit Commit Bot
Comment 7 2010-08-25 01:07:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.