Bug 44452

Summary: Add SynchronousLoader for ResourceHandleWin
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 43712    
Attachments:
Description Flags
Patch
aroben: review+
Patch
aroben: review+, aroben: commit-queue+
Patch none

Description Patrick R. Gansterer 2010-08-23 13:03:34 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-08-23 13:09:31 PDT 
Created attachment 65157 [details]
Patch

userAgent argument at WebCoreSynchronousLoader constructor will be used in a further patch
Comment 2 Adam Roben (:aroben) 2010-08-24 06:41:16 PDT 
Comment on attachment 65157 [details]
Patch

> +    WebCoreSynchronousLoader(ResourceError&, ResourceResponse &, Vector<char>&, const String& userAgent);

Extra space before & here.

r=me
Comment 3 Patrick R. Gansterer 2010-08-24 06:45:09 PDT 
Created attachment 65268 [details]
Patch

(In reply to comment #2)
> (From update of attachment 65157 [details])
> > +    WebCoreSynchronousLoader(ResourceError&, ResourceResponse &, Vector<char>&, const String& userAgent);
> 
> Extra space before & here.
Bug for stylecheker?
Comment 4 Adam Roben (:aroben) 2010-08-24 06:54:38 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 65157 [details] [details])
> > > +    WebCoreSynchronousLoader(ResourceError&, ResourceResponse &, Vector<char>&, const String& userAgent);
> > 
> > Extra space before & here.
> Bug for stylecheker?

Filing a bug would be great!
Comment 5 Adam Roben (:aroben) 2010-08-24 06:56:27 PDT 
Comment on attachment 65268 [details]
Patch

r=me
Comment 6 Patrick R. Gansterer 2010-08-24 07:11:11 PDT 
Created attachment 65271 [details]
Patch

Once again, sorry for the typo.
Comment 7 WebKit Commit Bot 2010-08-24 17:39:26 PDT 
Comment on attachment 65271 [details]
Patch

Clearing flags on attachment: 65271

Committed r65957: <http://trac.webkit.org/changeset/65957>
Comment 8 WebKit Commit Bot 2010-08-24 17:39:31 PDT 
All reviewed patches have been landed.  Closing bug.